Issue 6622047: state: make SetAdminPassword("") idempotent

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Issue 6622047: state: make SetAdminPassword("") idempotent

Can't Edit
Can't Publish+Mail
Start Review

Created:
11 years, 6 months ago by rog

Modified:
11 years, 6 months ago

Reviewers:
mp+128233

Visibility:
Public.

Description

state: make SetAdminPassword("") idempotent https://code.launchpad.net/~rogpeppe/juju-core/109-state-idempotent-setadminpassword/+merge/128233 (do not edit description out of merge proposal)

Patch Set 2 : state: make SetAdminPassword("") idempotent #

Total comments: 3

Patch Set 3 : state: make SetAdminPassword("") idempotent #

Created: 11 years, 6 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+13 lines, -2 lines)			Patch
A	[revision details]	View	1 2	1 chunk	+2 lines, -0 lines	0 comments	Download
M	state/state.go	View	1 2	1 chunk	+1 line, -1 line	0 comments	Download
M	state/state_test.go	View	1 2	2 chunks	+10 lines, -1 line	0 comments	Download

Messages

Total messages: 5

Expand All Messages | Collapse All Messages

niemeyer

LGTM https://codereview.appspot.com/6622047/diff/3001/state/state.go File state/state.go (right): https://codereview.appspot.com/6622047/diff/3001/state/state.go#newcode555 state/state.go:555: return fmt.Errorf("cannot remove admin user; %v", err) It ...

11 years, 6 months ago (2012-10-05 15:47:03 UTC) #4

rog

11 years, 6 months ago (2012-10-05 16:44:06 UTC) #5

*** Submitted:

state: make SetAdminPassword("") idempotent

R=TheMue, niemeyer
CC=
https://codereview.appspot.com/6622047

https://codereview.appspot.com/6622047/diff/3001/state/state.go
File state/state.go (right):

https://codereview.appspot.com/6622047/diff/3001/state/state.go#newcode555
state/state.go:555: return fmt.Errorf("cannot remove admin user; %v", err)
On 2012/10/05 15:47:04, niemeyer wrote:
> It was correctly following our convention before: s/;/:/

oops, debugging relic. done.

Expand All Messages | Collapse All Messages