Issue 6622046: Added a new constant for Debug Daemon's GetFeedbackLogs.

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Issue 6622046: Added a new constant for Debug Daemon's GetFeedbackLogs.

Can't Edit
Can't Publish+Mail
Start Review

Created:
9 years, 10 months ago by tudalex

Modified:
4 months, 1 week ago

Reviewers:
tudalex, satorux

Base URL:
http://git.chromium.org/chromiumos/platform/system_api.git@master

Visibility:
Public.

More Reviews

Description

Added a new constant for Debug Daemon's GetFeedbackLogs. BUG=None.

Patch Set 1 #

Created: 9 years, 10 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+1 line, -0 lines)			Patch
	M	dbus/service_constants.h	View		1 chunk	+1 line, -0 lines	0 comments	Download

Messages

Total messages: 2

Expand All Messages | Collapse All Messages

tudalex_gmail.com

9 years, 10 months ago (2012-10-05 16:36:54 UTC) #2

Sorry. New laptop and for some reason it had set codereview.appspot.com instead
of codereview.chromium.org.
On Oct 5, 2012, at 1:33 PM, tudalex@chromium.org wrote:

> Reviewers: satorux,
> 
> Description:
> Added a new constant for Debug Daemon's GetFeedbackLogs.
> 
> 
> BUG=None.
> 
> 
> Please review this at https://codereview.appspot.com/6622046/
> 
> Affected files:
>  M dbus/service_constants.h
> 
> 
> Index: dbus/service_constants.h
> diff --git a/dbus/service_constants.h b/dbus/service_constants.h
> index
1b29a36523bd26975dc901c3dada6ce56205812e..64eb54c2d748eabf4e2f332875ad4f6156865c19
100644
> --- a/dbus/service_constants.h
> +++ b/dbus/service_constants.h
> @@ -1159,6 +1159,7 @@ const char kSystraceStop[] = "SystraceStop";
> const char kSystraceStatus[] = "SystraceStatus";
> const char kGetLog[] = "GetLog";
> const char kGetAllLogs[] = "GetAllLogs";
> +const char kGetFeedbackLogs[] = "GetFeedbackLogs";
> const char kTestICMP[] = "TestICMP";
> }  // namespace debugd
> 
> 
>

Expand All Messages | Collapse All Messages