Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(1049)

Issue 6621062: iam: added DeleteUser method (Closed)

Can't Edit
Can't Publish+Mail
Start Review
Created:
11 years, 7 months ago by fss
Modified:
11 years, 6 months ago
Reviewers:
mp+128491
Visibility:
Public.

Description

iam: added DeleteUser method https://code.launchpad.net/~franciscosouza/goamz/iam-deleteuser/+merge/128491 (do not edit description out of merge proposal)

Patch Set 1 #

Total comments: 4

Patch Set 2 : iam: added DeleteUser method #

Patch Set 3 : iam: added DeleteUser method #

Unified diffs Side-by-side diffs Delta from patch set Stats (+40 lines, -0 lines) Patch
A [revision details] View 1 2 1 chunk +2 lines, -0 lines 0 comments Download
M iam/iam.go View 1 2 2 chunks +20 lines, -0 lines 0 comments Download
M iam/iam_test.go View 1 2 1 chunk +10 lines, -0 lines 0 comments Download
M iam/responses_test.go View 1 2 1 chunk +8 lines, -0 lines 0 comments Download

Messages

Total messages: 6
fss
Please take a look.
11 years, 7 months ago (2012-10-08 13:24:23 UTC) #1
niemeyer
Looks nice. Just a couple of trivials: https://codereview.appspot.com/6621062/diff/1/iam/iam.go File iam/iam.go (right): https://codereview.appspot.com/6621062/diff/1/iam/iam.go#newcode103 iam/iam.go:103: // DeleteUser ...
11 years, 7 months ago (2012-10-08 14:16:13 UTC) #2
fss
Please take a look. https://codereview.appspot.com/6621062/diff/1/iam/iam.go File iam/iam.go (right): https://codereview.appspot.com/6621062/diff/1/iam/iam.go#newcode103 iam/iam.go:103: // DeleteUser deletes a user ...
11 years, 7 months ago (2012-10-08 14:26:08 UTC) #3
niemeyer
LGTM
11 years, 6 months ago (2012-10-10 16:14:26 UTC) #4
fss
Please take a look.
11 years, 6 months ago (2012-10-10 17:55:46 UTC) #5
niemeyer
11 years, 6 months ago (2012-10-10 18:03:17 UTC) #6
*** Submitted:

iam: added DeleteUser method

R=niemeyer
CC=
https://codereview.appspot.com/6621062
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld f62528b