Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(23)

Issue 6618059: Add BMesh and WM symmetrize operators (Closed)

Can't Edit
Can't Publish+Mail
Start Review
Created:
4 years, 5 months ago by nicholasbishop
Modified:
4 years, 5 months ago
Reviewers:
brechtvl, bf-codereview
Base URL:
https://svn.blender.org/svnroot/bf-blender/trunk/blender/
Visibility:
Public.

Description

The symmetrize operation makes the input mesh elements symmetrical, but unlike mirroring it only copies in one direction. The edges and faces that cross the plane of symmetry are split as needed to enforce symmetry. The symmetrize operator can be controlled with the "direction" property, which combines the choices of symmetry plane and positive-negative/negative-positive. The enum for this is BMO_SymmDirection. Documentation: http://wiki.blender.org/index.php/User:Nicholasbishop/Symmetrize

Patch Set 1 #

Total comments: 5

Patch Set 2 : Update from review #

Patch Set 3 : Fix for faces not being deleted when it has vertices on the axis but none on the keep side #

Unified diffs Side-by-side diffs Delta from patch set Stats (+756 lines, -0 lines) Patch
source/blender/bmesh/CMakeLists.txt View 1 1 chunk +1 line, -0 lines 0 comments Download
source/blender/bmesh/intern/bmesh_opdefines.c View 1 2 chunks +24 lines, -0 lines 0 comments Download
source/blender/bmesh/intern/bmesh_operator_api.h View 1 1 chunk +10 lines, -0 lines 0 comments Download
source/blender/bmesh/intern/bmesh_operators_private.h View 1 1 chunk +1 line, -0 lines 0 comments Download
source/blender/bmesh/operators/bmo_symmetrize.c View 1 2 1 chunk +663 lines, -0 lines 0 comments Download
source/blender/editors/mesh/editmesh_tools.c View 1 3 chunks +53 lines, -0 lines 0 comments Download
source/blender/editors/mesh/mesh_intern.h View 1 1 chunk +2 lines, -0 lines 0 comments Download
source/blender/editors/mesh/mesh_ops.c View 1 1 chunk +2 lines, -0 lines 0 comments Download

Messages

Total messages: 10
nicholasbishop
4 years, 5 months ago (2012-10-07 16:40:40 UTC) #1
brechtvl
This is really quite cool, I was expecting a simple vertex coordinates symmetrize but it ...
4 years, 5 months ago (2012-10-12 10:47:24 UTC) #2
nicholasbishop
Update from review
4 years, 5 months ago (2012-10-14 01:43:03 UTC) #3
nicholasbishop
> Guess this todo and the one a few lines lower is not difficult to ...
4 years, 5 months ago (2012-10-14 01:43:59 UTC) #4
nicholasbishop
Fix for faces not being deleted when it has vertices on the axis but none ...
4 years, 5 months ago (2012-10-14 03:02:10 UTC) #5
brechtvl
LGTM Forgot one thing, this tool doesn't seem to be in any menu, but maybe ...
4 years, 5 months ago (2012-10-15 09:52:43 UTC) #6
brechtvl
LGTM Forgot one thing, this tool doesn't seem to be in any menu, but maybe ...
4 years, 5 months ago (2012-10-15 09:52:43 UTC) #7
nicholasbishop
On 2012/10/15 09:52:43, brechtvl wrote: Good point, what menu do you think it should go ...
4 years, 5 months ago (2012-10-15 13:58:26 UTC) #8
brechtvl
There doesn't seem to be a perfect for any of the submenus (maybe Mirror, but ...
4 years, 5 months ago (2012-10-15 14:44:59 UTC) #9
nicholasbishop
4 years, 5 months ago (2012-10-15 23:55:15 UTC) #10
Added the menu entries and committed as r51356.

Thanks for reviewing :)
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld 80a51fa-tainted