Issue 6615071: worker/provisioner: initial password for machine

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Issue 6615071: worker/provisioner: initial password for machine

Can't Edit
Can't Publish+Mail
Start Review

Created:
11 years, 6 months ago by rog

Modified:
11 years, 6 months ago

Reviewers:
mp+128961

Visibility:
Public.

Description

worker/provisioner: initial password for machine https://code.launchpad.net/~rogpeppe/juju-core/115-set-entity-passwords/+merge/128961 (do not edit description out of merge proposal)

Patch Set 2 : worker/provisioner: initial password for machine #

Patch Set 3 : worker/provisioner: initial password for machine #

Total comments: 2

Patch Set 4 : worker/provisioner: initial password for machine #

Created: 11 years, 6 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+46 lines, -6 lines)			Patch
A	[revision details]	View	1	1 chunk	+2 lines, -0 lines	0 comments	Download
M	trivial/password.go	View		1 chunk	+9 lines, -0 lines	0 comments	Download
M	trivial/password_test.go	View		2 chunks	+12 lines, -0 lines	0 comments	Download
M	worker/provisioner/provisioner.go	View		5 chunks	+14 lines, -6 lines	0 comments	Download
M	worker/provisioner/provisioner_test.go	View		1 chunk	+9 lines, -0 lines	0 comments	Download

Messages

Total messages: 3

Expand All Messages | Collapse All Messages

niemeyer

LGTM https://codereview.appspot.com/6615071/diff/4001/worker/provisioner/provisioner.go File worker/provisioner/provisioner.go (right): https://codereview.appspot.com/6615071/diff/4001/worker/provisioner/provisioner.go#newcode209 worker/provisioner/provisioner.go:209: log.Printf("provisioner: machine %v already started as instance %q", ...

11 years, 6 months ago (2012-10-10 15:20:58 UTC) #2

rog

11 years, 6 months ago (2012-10-10 15:56:27 UTC) #3

*** Submitted:

worker/provisioner: initial password for machine

R=niemeyer
CC=
https://codereview.appspot.com/6615071

https://codereview.appspot.com/6615071/diff/4001/worker/provisioner/provision...
File worker/provisioner/provisioner.go (right):

https://codereview.appspot.com/6615071/diff/4001/worker/provisioner/provision...
worker/provisioner/provisioner.go:209: log.Printf("provisioner: machine %v
already started as instance %q", m, instId)
On 2012/10/10 15:20:58, niemeyer wrote:
> We've been going in the opposite direction and dropping these prefixes
> everywhere. We have to make up our minds and talk about it rather than
> implicitly put things on and off.

ok. i'll leave them in for the time being (there are lots of places that still
have them) and we'll decide on some policy.

Expand All Messages | Collapse All Messages