Issue 6615063: environs/dummy: start support for global fw mode

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Issue 6615063: environs/dummy: start support for global fw mode

Can't Edit
Can't Publish+Mail
Start Review

Created:
11 years, 7 months ago by niemeyer

Modified:
11 years, 7 months ago

Reviewers:
mp+128554, rog, TheMue

Visibility:
Public.

Description

environs/dummy: start support for global fw mode This also disables the global firewall mode test. It's unfinished and half-baked at the moment. https://code.launchpad.net/~niemeyer/juju-core/dummy-global-fw-mode/+merge/128554 (do not edit description out of merge proposal)

Patch Set 1 #

Patch Set 2 : environs/dummy: start support for global fw mode #

Patch Set 3 : environs/dummy: start support for global fw mode #

Patch Set 4 : environs/dummy: start support for global fw mode #

Patch Set 5 : environs/dummy: start support for global fw mode #

Created: 11 years, 7 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+32 lines, -10 lines)			Patch
A	[revision details]	View	1 chunk	+2 lines, -0 lines	0 comments	Download
M	environs/dummy/environs.go	View	6 chunks	+28 lines, -10 lines	0 comments	Download
M	environs/jujutest/livetests.go	View	1 chunk	+2 lines, -0 lines	0 comments	Download

Messages

Total messages: 4

Expand All Messages | Collapse All Messages

rog

On 2012/10/08 17:37:23, niemeyer wrote: > Please take a look. LGTM

11 years, 7 months ago (2012-10-08 17:40:55 UTC) #2

niemeyer

11 years, 7 months ago (2012-10-08 19:36:27 UTC) #4

*** Submitted:

environs/dummy: start support for global fw mode

This also disables the global firewall mode test. It's
unfinished and half-baked at the moment.

R=rog, TheMue
CC=
https://codereview.appspot.com/6615063

Expand All Messages | Collapse All Messages