Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(46)

Issue 6615060: code review 6615060: doc/contribute.html: assorted fixes (Closed)

Can't Edit
Can't Publish+Mail
Start Review
Created:
12 years, 5 months ago by minux1
Modified:
12 years, 5 months ago
Reviewers:
CC:
golang-dev, adg, r
Visibility:
Public.

Description

doc/contribute.html: assorted fixes 0. windows uses all.bat instead of ./all.bash 1. correct expected all.bash output 2. mention you need to use an application specific password if you're using 2-step verification 3. note you can edit files included in CL by 'hg change NNNN' or 'hg file'

Patch Set 1 #

Patch Set 2 : diff -r 3350c94fe6b7 https://code.google.com/p/go #

Patch Set 3 : diff -r 3350c94fe6b7 https://code.google.com/p/go #

Patch Set 4 : diff -r 3350c94fe6b7 https://code.google.com/p/go #

Patch Set 5 : diff -r 3350c94fe6b7 https://code.google.com/p/go #

Patch Set 6 : diff -r 3350c94fe6b7 https://code.google.com/p/go #

Patch Set 7 : diff -r 4261c157f226 https://code.google.com/p/go #

Total comments: 1

Patch Set 8 : diff -r 8209534dab87 https://code.google.com/p/go/ #

Total comments: 5

Patch Set 9 : diff -r aa2adb62e2ce https://code.google.com/p/go #

Total comments: 1

Patch Set 10 : diff -r aa2adb62e2ce https://code.google.com/p/go #

Patch Set 11 : diff -r bc50fc903d6e https://code.google.com/p/go/ #

Patch Set 12 : diff -r aa2adb62e2ce https://code.google.com/p/go/ #

Unified diffs Side-by-side diffs Delta from patch set Stats (+8 lines, -15 lines) Patch
M doc/contribute.html View 1 2 3 4 5 6 7 8 9 3 chunks +8 lines, -15 lines 0 comments Download

Messages

Total messages: 7
minux1
Hello golang-dev@googlegroups.com (cc: golang-dev@googlegroups.com), I'd like you to review this change to https://code.google.com/p/go
12 years, 5 months ago (2012-10-08 11:10:51 UTC) #1
adg
LGTM https://codereview.appspot.com/6615060/diff/11002/doc/contribute.html File doc/contribute.html (right): https://codereview.appspot.com/6615060/diff/11002/doc/contribute.html#newcode282 doc/contribute.html:282: If you need to re-edit the change description, ...
12 years, 5 months ago (2012-10-10 00:05:28 UTC) #2
minux1
PTAL. following Daniel's suggestion, i added coverage of 'hg file' command.
12 years, 5 months ago (2012-10-10 14:55:42 UTC) #3
r
https://codereview.appspot.com/6615060/diff/15001/doc/contribute.html File doc/contribute.html (right): https://codereview.appspot.com/6615060/diff/15001/doc/contribute.html#newcode45 doc/contribute.html:45: (if you're contributing on Windows, use <code>all.bat</code> instead drop ...
12 years, 5 months ago (2012-10-10 20:05:59 UTC) #4
minux1
Thank you very much r, all done, PTAL.
12 years, 5 months ago (2012-10-11 09:42:28 UTC) #5
r
LGTM https://codereview.appspot.com/6615060/diff/19001/doc/contribute.html File doc/contribute.html (right): https://codereview.appspot.com/6615060/diff/19001/doc/contribute.html#newcode126 doc/contribute.html:126: application-specific password and use that when prompted for ...
12 years, 5 months ago (2012-10-11 09:43:40 UTC) #6
minux1
12 years, 5 months ago (2012-10-11 15:34:20 UTC) #7
*** Submitted as http://code.google.com/p/go/source/detail?r=caf30a0fbd77 ***

doc/contribute.html: assorted fixes
0. windows uses all.bat instead of ./all.bash
1. correct expected all.bash output
2. mention you need to use an application specific password
if you're using 2-step verification
3. note you can edit files included in CL by 'hg change NNNN'
or 'hg file'

R=golang-dev, adg, r
CC=golang-dev
http://codereview.appspot.com/6615060
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld f62528b