code review 6615060: doc/contribute.html: assorted fixes

doc/contribute.html

 <!--{
         "Title": "Contribution Guidelines"
 }-->
 
 <h2 id="Introduction">Introduction</h2>
 
 <p>
 This document explains how to contribute changes to the Go project.
 It assumes you have installed Go using the
 <a href="/doc/install/source">installation instructions</a> and
@@ skipping 28 matching lines @@
 <h2 id="Testing">Testing redux</h2>
 
 <p>
 You've <a href="code.html">written and tested your code</a>, but
 before sending code out for review, run all the tests for the whole
 tree to make sure the changes don't break other packages or programs:
 </p>
 
 <pre>
 cd $GOROOT/src
-./all.bash
-</pre>
-
-<p>
-The final line printed by <code>make all</code> should be of the form:
-</p>
-
-<pre>
-<i>N</i> known bugs; 0 unexpected bugs
-</pre>
-
-<p>
-The value of <i>N</i> varies over time, but the line must
-say &ldquo;<code>0 unexpected bugs</code>&rdquo; and must not
-add &ldquo;<code>test output differs</code>.&rdquo;
-</p>
-
+./all.bash    # On Windows, run all.bat
+</pre>
+
+<p>
+After running for a while, the command should print "<code>ALL TESTS PASSED</code>".
+</p>
 
 <h2 id="Code_review">Code review</h2>
 
 <p>
 Changes to Go must be reviewed before they are submitted,
 no matter who makes the change.
 (In exceptional cases, such as fixing a build, the review can
 follow shortly after submitting.)
 A Mercurial extension helps manage the code review process.
 The extension is included in the Go source tree but needs
@@ skipping 50 matching lines @@
 <p>
 The code review server uses a Google Account to authenticate.
 (If you can use the account to
 <a href="https://www.google.com/accounts/Login?hl=en&amp;continue=http://www.google.com/">sign in at google.com</a>,
 you can use it to sign in to the code review server.
 The email address you use on the Code Review site
 will be recorded in the <a href="http://code.google.com/p/go/source/list">Mercurial change log</a>
 and in the <a href="/CONTRIBUTORS"><code>CONTRIBUTORS</code></a> file.
 You can <a href="https://www.google.com/accounts/NewAccount">create a Google Account</a>
 associated with any address where you receive email.
+If you've enabled the two-step verification feature, don't forget to generate an
+application-specific password and use that when prompted for a password.
 </p>
 
 <pre>
 $ cd $GOROOT
 $ hg code-login
 Email (login for uploading to codereview.appspot.com): rsc@golang.org
 Password for rsc@golang.org:
 
 Saving authentication cookies to /Users/rsc/.codereview_upload_cookies_codereview.appspot.com
 </pre>
@@ skipping 132 matching lines @@
 <p>
 The code review server assigns your change an issue number and URL,
 which <code>hg change</code> will print, something like:
 </p>
 
 <pre>
 CL created: http://codereview.appspot.com/99999
 </pre>
 
 <p>
-If you need to re-edit the change description,
-run <code>hg change 99999</code>.
+If you need to re-edit the change description, or change the files included in the CL,
+run <code>hg change 99999</code>. Alternatively, you can use <code>hg file 99999 somefile</code>
+to add <code>somefile</code> to CL 99999, and use <code>hg file -d 99999 somefile</code> to remove
+<code>somefile</code> from the CL.
 </p>
 
 <p>
 You can see a list of your pending changes by running <code>hg pending</code> (<code>hg p</code> for short).
 </p>
 
 
 <h3>Synchronize your client</h3>
 
 <p>While you were working, others might have submitted changes
@@ skipping 229 matching lines @@
 This rigmarole needs to be done only for your first submission.
 </p>
 
 <p>Code that you contribute should use the standard copyright header:</p>
 
 <pre>
 // Copyright 2012 The Go Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style
 // license that can be found in the LICENSE file.
 </pre>