Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(764)

Issue 6613055: Implements a pseudo-patience-diff SequenceMatcher for Rietveld. (Closed)

Can't Edit
Can't Publish+Mail
Start Review
Created:
11 years, 5 months ago by macourteau2
Modified:
11 years, 5 months ago
Reviewers:
macourteau1, M-A
CC:
codereview-discuss_googlegroups.com
Visibility:
Public.

Description

Implements a pseudo-patience-diff SequenceMatcher for Rietveld.

Patch Set 1 #

Patch Set 2 : Removed useless print. #

Total comments: 6

Patch Set 3 : Address comments from maruel@. #

Patch Set 4 : Minor fix. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+88 lines, -7 lines) Patch
M codereview/engine.py View 3 chunks +3 lines, -2 lines 0 comments Download
M codereview/intra_region_diff.py View 1 3 chunks +5 lines, -4 lines 0 comments Download
M codereview/patching.py View 2 chunks +2 lines, -1 line 0 comments Download
A codereview/patiencediff.py View 1 2 3 1 chunk +78 lines, -0 lines 0 comments Download

Messages

Total messages: 3
macourteau2
11 years, 5 months ago (2012-10-05 19:19:47 UTC) #1
M-A
I didn't review the algorithm but the rest of the change lgtm. cc'ing the mailing ...
11 years, 5 months ago (2012-10-05 19:30:11 UTC) #2
macourteau1
11 years, 5 months ago (2012-10-05 19:33:16 UTC) #3
https://codereview.appspot.com/6613055/diff/2002/codereview/patiencediff.py
File codereview/patiencediff.py (right):

https://codereview.appspot.com/6613055/diff/2002/codereview/patiencediff.py#n...
codereview/patiencediff.py:18: """Provides s SequenceMatcher that prefers longer
"first" matches to longer
On 2012/10/05 19:30:11, M-A wrote:
> remove extra 's'

Done.

https://codereview.appspot.com/6613055/diff/2002/codereview/patiencediff.py#n...
codereview/patiencediff.py:22: def __init__(self, isjunk=None, a='', b=''):
On 2012/10/05 19:30:11, M-A wrote:
> Remove lines 21-24, they are not needed.

Done.

https://codereview.appspot.com/6613055/diff/2002/codereview/patiencediff.py#n...
codereview/patiencediff.py:26: """Return list of triples describing matching
subsequences.
On 2012/10/05 19:30:11, M-A wrote:
> Returns

Done.
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld f62528b