Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(36)

Issue 66130043: code review 66130043: cmd/pack: add 'c' command to create archive (Closed)

Can't Edit
Can't Publish+Mail
Start Review
Created:
11 years, 4 months ago by rsc
Modified:
11 years, 4 months ago
Reviewers:
r, gobot
CC:
r, golang-codereviews
Visibility:
Public.

Description

cmd/pack: add 'c' command to create archive When Go 1.3 is released, this will keep existing Go 1.2 build scripts that use 'go tool pack grc' working. For efficiency, such scripts should be changed to use 6g -pack instead, but keeping the old behavior available enables a more graceful transition.

Patch Set 1 #

Patch Set 2 : diff -r ea795573aef0 https://code.google.com/p/go/ #

Total comments: 2

Patch Set 3 : diff -r 19355fdfb5aa https://code.google.com/p/go/ #

Unified diffs Side-by-side diffs Delta from patch set Stats (+135 lines, -10 lines) Patch
M src/cmd/pack/doc.go View 1 2 chunks +2 lines, -1 line 0 comments Download
M src/cmd/pack/pack.go View 1 2 7 chunks +89 lines, -9 lines 0 comments Download
M src/cmd/pack/pack_test.go View 1 2 chunks +44 lines, -0 lines 0 comments Download

Messages

Total messages: 5
rsc
Hello r (cc: golang-codereviews@googlegroups.com), I'd like you to review this change to https://code.google.com/p/go/
11 years, 4 months ago (2014-02-19 20:32:06 UTC) #1
r
LGTM https://codereview.appspot.com/66130043/diff/20001/src/cmd/pack/pack.go File src/cmd/pack/pack.go (right): https://codereview.appspot.com/66130043/diff/20001/src/cmd/pack/pack.go#newcode38 src/cmd/pack/pack.go:38: Where op is one of cprtx optionally followed ...
11 years, 4 months ago (2014-02-19 21:36:05 UTC) #2
rsc
done
11 years, 4 months ago (2014-02-19 22:08:29 UTC) #3
rsc
*** Submitted as https://code.google.com/p/go/source/detail?r=48a4a9afb88b *** cmd/pack: add 'c' command to create archive When Go 1.3 ...
11 years, 4 months ago (2014-02-19 22:08:47 UTC) #4
gobot
11 years, 4 months ago (2014-02-19 22:34:05 UTC) #5
Message was sent while issue was closed.
This CL appears to have broken the plan9-386-cnielsen builder.
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld f62528b