Issue 66110043: code review 66110043: cmd/gc: fix printf format in typecheck.c

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Issue 66110043: code review 66110043: cmd/gc: fix printf format in typecheck.c (Closed)

Can't Edit
Can't Publish+Mail
Start Review

Created:
11 years, 1 month ago by r

Modified:
11 years, 1 month ago

Reviewers:
rsc, bradfitz

CC:
rsc, bradfitz, golang-codereviews, rick

Visibility:
Public.

Description

cmd/gc: fix printf format in typecheck.c There are probably more of these, but bound and len are 64 bits so use %lld in message about array index out of bounds. Fixes the 386 build.

Patch Set 1 #

Created: 11 years, 1 month ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+1 line, -1 line)			Patch
	M	src/cmd/gc/typecheck.c	View		1 chunk	+1 line, -1 line	0 comments	Download

Messages

Total messages: 4

Expand All Messages | Collapse All Messages

Hello rsc (cc: golang-codereviews@googlegroups.com, rickarnoldjr@gmail.com), I'd like you to review this change to https://code.google.com/p/go

11 years, 1 month ago (2014-02-19 20:00:07 UTC) #1

rsc

11 years, 1 month ago (2014-02-19 20:50:55 UTC) #4

*** Submitted as https://code.google.com/p/go/source/detail?r=916d82f583b7 ***

cmd/gc: fix printf format in typecheck.c
There are probably more of these, but bound and len are 64 bits so use %lld
in message about array index out of bounds.
Fixes the 386 build.

LGTM=bradfitz, rsc
R=rsc, bradfitz
CC=golang-codereviews, rickarnoldjr
https://codereview.appspot.com/66110043

Committer: Russ Cox <rsc@golang.org>

Expand All Messages | Collapse All Messages