Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(761)

Issue 6610054: code review 6610054: cmd/gc: escape analysis to track flow of in to out para... (Closed)

Can't Edit
Can't Publish+Mail
Start Review
Created:
10 years, 2 months ago by lvd
Modified:
10 years, 1 month ago
Reviewers:
rog
CC:
rsc, golang-dev
Visibility:
Public.

Description

cmd/gc: escape analysis to track flow of in to out parameters. includes step 0: synthesize outparams, from 6600044 step 1: give outparams loopdepth 0 and verify unchanged results step 2: generate esc:$mask tags, but still tie to sink if a param has mask != 0 next step: use in esccall (and ORETURN with implicit OAS2FUNC) to avoid tying to sink

Patch Set 1 #

Patch Set 2 : diff -r 81bcdaeedc63 https://go.googlecode.com/hg/ #

Patch Set 3 : diff -r 81bcdaeedc63 https://go.googlecode.com/hg/ #

Patch Set 4 : diff -r 32c1ce44286f https://go.googlecode.com/hg/ #

Total comments: 2

Patch Set 5 : diff -r 06ac3095d784 https://go.googlecode.com/hg/ #

Total comments: 1
Unified diffs Side-by-side diffs Delta from patch set Stats (+84 lines, -16 lines) Patch
M src/cmd/gc/esc.c View 1 10 chunks +81 lines, -16 lines 1 comment Download
M src/cmd/gc/go.h View 1 1 chunk +3 lines, -0 lines 0 comments Download

Messages

Total messages: 6
lvd
Hello rsc@golang.org (cc: golang-dev@googlegroups.com), I'd like you to review this change to https://go.googlecode.com/hg/
10 years, 1 month ago (2012-10-18 15:57:31 UTC) #1
rsc
LGTM https://codereview.appspot.com/6610054/diff/7001/src/cmd/gc/esc.c File src/cmd/gc/esc.c (right): https://codereview.appspot.com/6610054/diff/7001/src/cmd/gc/esc.c#newcode511 src/cmd/gc/esc.c:511: // OAS2FUNC in disguise Seems like we need ...
10 years, 1 month ago (2012-10-21 21:59:53 UTC) #2
lvd
https://codereview.appspot.com/6610054/diff/7001/src/cmd/gc/esc.c File src/cmd/gc/esc.c (right): https://codereview.appspot.com/6610054/diff/7001/src/cmd/gc/esc.c#newcode511 src/cmd/gc/esc.c:511: // OAS2FUNC in disguise On 2012/10/21 21:59:53, rsc wrote: ...
10 years, 1 month ago (2012-10-22 08:13:07 UTC) #3
lvd
*** Submitted as http://code.google.com/p/go/source/detail?r=dede8dc61bf6 *** cmd/gc: escape analysis to track flow of in to out ...
10 years, 1 month ago (2012-10-22 08:18:22 UTC) #4
rog
https://codereview.appspot.com/6610054/diff/10002/src/cmd/gc/esc.c File src/cmd/gc/esc.c (right): https://codereview.appspot.com/6610054/diff/10002/src/cmd/gc/esc.c#newcode214 src/cmd/gc/esc.c:214: static Strlit *tags[16] = { nil, nil, nil, nil, ...
10 years, 1 month ago (2012-10-22 10:13:08 UTC) #5
lvd
10 years, 1 month ago (2012-10-22 11:32:34 UTC) #6
of course.  I'll fix that in 6741044


On Mon, Oct 22, 2012 at 12:13 PM, <rogpeppe@gmail.com> wrote:

>
>
https://codereview.appspot.**com/6610054/diff/10002/src/**cmd/gc/esc.c<https:...
> File src/cmd/gc/esc.c (right):
>
> https://codereview.appspot.**com/6610054/diff/10002/src/**
>
cmd/gc/esc.c#newcode214<https://codereview.appspot.com/6610054/diff/10002/src/cmd/gc/esc.c#newcode214>
> src/cmd/gc/esc.c:214: static Strlit *tags[16] = { nil, nil, nil, nil,
> nil, nil, nil, nil, nil, nil, nil, nil, nil, nil, nil, nil };
> isn't the initialiser unnecessary.?
>
>
https://codereview.appspot.**com/6610054/<https://codereview.appspot.com/6610...
>
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld f62528b