Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(1152)

Issue 6604061: cmd/jujud: connect with initial password

Can't Edit
Can't Publish+Mail
Start Review
Created:
11 years, 6 months ago by rog
Modified:
11 years, 6 months ago
Reviewers:
mp+128943
Visibility:
Public.

Description

cmd/jujud: connect with initial password We don't yet change the password after connection, and for the moment it's optional otherwise live tests fail because the code for setting up entity passwords isn't yet there. https://code.launchpad.net/~rogpeppe/juju-core/117-jujud-use-initial-password/+merge/128943 (do not edit description out of merge proposal)

Patch Set 1 #

Patch Set 2 : cmd/jujud: connect with initial password #

Patch Set 3 : cmd/jujud: connect with initial password #

Unified diffs Side-by-side diffs Delta from patch set Stats (+63 lines, -26 lines) Patch
A [revision details] View 1 chunk +2 lines, -0 lines 0 comments Download
M cmd/jujud/agent.go View 1 chunk +14 lines, -0 lines 0 comments Download
M cmd/jujud/machine.go View 1 chunk +1 line, -1 line 0 comments Download
M cmd/jujud/machine_test.go View 5 chunks +32 lines, -18 lines 0 comments Download
M cmd/jujud/unit.go View 1 chunk +1 line, -1 line 0 comments Download
M cmd/jujud/unit_test.go View 4 chunks +13 lines, -6 lines 0 comments Download

Messages

Total messages: 3
rog
Please take a look.
11 years, 6 months ago (2012-10-10 14:12:20 UTC) #1
niemeyer
LGTM
11 years, 6 months ago (2012-10-10 14:14:20 UTC) #2
rog
11 years, 6 months ago (2012-10-10 14:16:31 UTC) #3
*** Submitted:

cmd/jujud: connect with initial password

We don't yet change the password after connection,
and for the moment it's optional otherwise live
tests fail because the code for setting up entity
passwords isn't yet there.

R=niemeyer
CC=
https://codereview.appspot.com/6604061
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld f62528b