Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(1349)

Issue 6604060: Correct maas api usage maas-tags constraint

Can't Edit
Can't Publish+Mail
Start Review
Created:
11 years, 6 months ago by gz
Modified:
11 years, 6 months ago
Reviewers:
hazmat, mp+128933
Visibility:
Public.

Description

Correct maas api usage maas-tags constraint Currently MaaS is incorrectly passed a reserialised version of the maas-tags constraint rather than the original string, which prevents acquiring any nodes by tag. Instead the 'convert' callback of the constraint should do nothing apart from rough validation of tag names. https://code.launchpad.net/~gz/juju/maas_tag_conversion_1064734/+merge/128933 (do not edit description out of merge proposal)

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+4 lines, -1 line) Patch
A [revision details] View 1 chunk +2 lines, -0 lines 0 comments Download
M juju/providers/maas/provider.py View 1 chunk +1 line, -1 line 0 comments Download
M juju/providers/maas/tests/test_provider.py View 1 chunk +1 line, -0 lines 0 comments Download

Messages

Total messages: 2
gz
Please take a look.
11 years, 6 months ago (2012-10-10 13:22:45 UTC) #1
hazmat
11 years, 6 months ago (2012-10-10 15:12:08 UTC) #2
This still strips operators
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld f62528b