Stop resolving uri fragments into absolute uris (Issue 1539)

Earlier change made URL resolution too aggressive which interacts poorly 
cases where a link is just a url fragment.  This change rewrites uris
which are just uri fragments the same as regular uri fragments ie. rewrites
to add a idsuffix

@5080

[metaweta, 2012-10-04 04:29:08]

lgtm

https://codereview.appspot.com/6603049/diff/1/src/com/google/caja/plugin/doma...
File src/com/google/caja/plugin/domado.js (right):

https://codereview.appspot.com/6603049/diff/1/src/com/google/caja/plugin/doma...
src/com/google/caja/plugin/domado.js:1803: // URI fragments reference contents
within the document and arent subject
long line, "aren't"

https://codereview.appspot.com/6603049/diff/1/tests/com/google/caja/plugin/es...
File tests/com/google/caja/plugin/es53-test-target-attribute-presets.js (right):

https://codereview.appspot.com/6603049/diff/1/tests/com/google/caja/plugin/es...
tests/com/google/caja/plugin/es53-test-target-attribute-presets.js:34:
function(html, str) { html.indexOf(str) === 1; });
This asserts that str appears at position 1, not that it's merely contained in
html.  Is that what you meant?

https://codereview.appspot.com/6603049/diff/1/tests/com/google/caja/plugin/es...
tests/com/google/caja/plugin/es53-test-target-attribute-presets.js:49: var
expected = Array.prototype.slice.call(arguments, 2);
If you want you can shorten this to [].slice.call(...)

[Jasvir, 2012-10-04 05:24:58]

https://codereview.appspot.com/6603049/diff/1/tests/com/google/caja/plugin/es...
File tests/com/google/caja/plugin/es53-test-target-attribute-presets.js (right):

https://codereview.appspot.com/6603049/diff/1/tests/com/google/caja/plugin/es...
tests/com/google/caja/plugin/es53-test-target-attribute-presets.js:34:
function(html, str) { html.indexOf(str) === 1; });
Error when refactoring this test into makers.  Done.

https://codereview.appspot.com/6603049/diff/1/tests/com/google/caja/plugin/es...
tests/com/google/caja/plugin/es53-test-target-attribute-presets.js:49: var
expected = Array.prototype.slice.call(arguments, 2);
On 2012/10/04 04:29:09, metaweta wrote:
> If you want you can shorten this to [].slice.call(...)

Done.

[metaweta, 2012-10-04 05:38:39]

https://codereview.appspot.com/6603049/diff/5001/tests/com/google/caja/plugin...
File tests/com/google/caja/plugin/es53-test-target-attribute-presets.js (right):

https://codereview.appspot.com/6603049/diff/5001/tests/com/google/caja/plugin...
tests/com/google/caja/plugin/es53-test-target-attribute-presets.js:34:
function(html, str) { html.indexOf(str) === -1; });
You got the senses opposite: -1 means "does not contain".

[Jasvir, 2012-10-04 05:55:24]

https://codereview.appspot.com/6603049/diff/5001/tests/com/google/caja/plugin...
File tests/com/google/caja/plugin/es53-test-target-attribute-presets.js (right):

https://codereview.appspot.com/6603049/diff/5001/tests/com/google/caja/plugin...
tests/com/google/caja/plugin/es53-test-target-attribute-presets.js:34:
function(html, str) { html.indexOf(str) === -1; });
...and hence the call to fail.  I can reverse the test and negate the predicate
if that'll make it clearer.

[metaweta, 2012-10-04 13:51:50]

lgtm

https://codereview.appspot.com/6603049/diff/5001/tests/com/google/caja/plugin...
File tests/com/google/caja/plugin/es53-test-target-attribute-presets.js (right):

https://codereview.appspot.com/6603049/diff/5001/tests/com/google/caja/plugin...
tests/com/google/caja/plugin/es53-test-target-attribute-presets.js:34:
function(html, str) { html.indexOf(str) === -1; });
On 2012/10/04 05:55:24, Jasvir wrote:
> ...and hence the call to fail.  I can reverse the test and negate the
predicate
> if that'll make it clearer.
Please do, thanks.

[metaweta, 2012-10-09 20:09:17]

please close