Issue 6601067: cmd/{jujud,juju}: no JujuConnSuite in btstrp test

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Issue 6601067: cmd/{jujud,juju}: no JujuConnSuite in btstrp test

Can't Edit
Can't Publish+Mail
Start Review

Created:
11 years, 6 months ago by rog

Modified:
11 years, 6 months ago

Reviewers:
mp+129395

Visibility:
Public.

Description

cmd/{jujud,juju}: no JujuConnSuite in btstrp test The tests should not be running on an already-bootstrapped environment, which is what JujuConnSuite provides. https://code.launchpad.net/~rogpeppe/juju-core/127-jujud-bootstrap-do-not-use-jujuconnsuite/+merge/129395 (do not edit description out of merge proposal)

Patch Set 1 #

Patch Set 2 : cmd/jujud: no JujuConnSuite in bootstrap test #

Patch Set 3 : cmd/{jujud,juju}: no JujuConnSuite in btstrp test #

Patch Set 4 : cmd/{jujud,juju}: no JujuConnSuite in btstrp test #

Patch Set 5 : cmd/{jujud,juju}: no JujuConnSuite in btstrp test #

Patch Set 6 : cmd/{jujud,juju}: no JujuConnSuite in btstrp test #

Patch Set 7 : cmd/{jujud,juju}: no JujuConnSuite in btstrp test #

Created: 11 years, 6 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+112 lines, -46 lines)			Patch
A	[revision details]	View	1 2 3 4 5	1 chunk	+2 lines, -0 lines	0 comments	Download
A	cmd/juju/bootstrap_test.go	View	1 2	1 chunk	+70 lines, -0 lines	0 comments	Download
M	cmd/juju/cmd_test.go	View	1 2	2 chunks	+0 lines, -37 lines	0 comments	Download
M	cmd/jujud/bootstrap_test.go	View		8 chunks	+40 lines, -9 lines	0 comments	Download

Messages

Total messages: 9

Expand All Messages | Collapse All Messages

rog

11 years, 6 months ago (2012-10-15 13:35:59 UTC) #9

*** Submitted:

cmd/{jujud,juju}: no JujuConnSuite in btstrp test

The tests should not be running on an already-bootstrapped
environment, which is what JujuConnSuite provides.

R=fwereade, niemeyer
CC=
https://codereview.appspot.com/6601067

Expand All Messages | Collapse All Messages