Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(780)

Issue 6601060: Give integer maas constraints without decimal

Can't Edit
Can't Publish+Mail
Start Review
Created:
11 years, 6 months ago by gz
Modified:
11 years, 6 months ago
Reviewers:
hazmat, mp+127987
Visibility:
Public.

Description

Give integer maas constraints without decimal Currently generic cpu and mem constraints are cast to float inside juju, this isn't really useful for memory in MB or cpu count as used by MaaS. It also happens to upset the current code. Giving the integer form instead is reasonable. https://code.launchpad.net/~gz/juju/maas_int_constraints_1061286/+merge/127987 (do not edit description out of merge proposal)

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+16 lines, -9 lines) Patch
A [revision details] View 1 chunk +2 lines, -0 lines 0 comments Download
M juju/providers/maas/maas.py View 2 chunks +12 lines, -7 lines 0 comments Download
M juju/providers/maas/tests/test_maas.py View 2 chunks +2 lines, -2 lines 0 comments Download

Messages

Total messages: 2
gz
Please take a look.
11 years, 6 months ago (2012-10-04 11:41:21 UTC) #1
hazmat
11 years, 6 months ago (2012-10-04 14:17:51 UTC) #2
lgtm, fwiw, the float usage is based on some of the cloud providers using them
for instance type sizing for cpu. the conversion at usage/provider interaction
time here looks good.
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld f62528b