cmd: add tests for --format=nnn

cmd: add tests for --format=nnn

Add checks for --format=nnn flag parsing.

This will break for people who have not updated gnuflag to the latest version, this is a good thing.

https://code.launchpad.net/~dave-cheney/juju-core/013-cmd-additional-format-tests/+merge/127921

(do not edit description out of merge proposal)

[dfc, 2012-10-04 01:34:45]

Please take a look.

[fwereade, 2012-10-04 09:16:41]

LGTM

[niemeyer, 2012-10-04 21:24:20]

The intention is great, but NOT LGTM as it is.

https://codereview.appspot.com/6601056/diff/1/cmd/output_test.go
File cmd/output_test.go (right):

https://codereview.appspot.com/6601056/diff/1/cmd/output_test.go#newcode109
cmd/output_test.go:109: args = []string{"--format=" + format}
This isn't the place to test that parsing works at all. Having the test is a
good idea, but let's have a tiny and isolated test called TestArgParsing whose
only purpose is to verify that "--foo bar" and "--foo=bar" are equivalent,
rather than duplicating all these unrelated verifications.

[dfc, 2012-10-04 22:54:27]

https://codereview.appspot.com/6601056/diff/1/cmd/output_test.go
File cmd/output_test.go (right):

https://codereview.appspot.com/6601056/diff/1/cmd/output_test.go#newcode109
cmd/output_test.go:109: args = []string{"--format=" + format}
On 2012/10/04 21:24:21, niemeyer wrote:
> This isn't the place to test that parsing works at all. Having the test is a
> good idea, but let's have a tiny and isolated test called TestArgParsing whose
> only purpose is to verify that "--foo bar" and "--foo=bar" are equivalent,
> rather than duplicating all these unrelated verifications.

Fair enough, i'll add that test with a comment.

[dfc, 2012-10-05 00:00:27]

Please take a look.

[niemeyer, 2012-10-05 00:24:04]

LGTM, thanks!

[dfc, 2012-10-05 00:43:32]

*** Submitted:

cmd: add tests for --format=nnn

Add checks for --format=nnn flag parsing.

This will break for people who have not updated gnuflag to the latest version,
this is a good thing.

R=fwereade, niemeyer
CC=
https://codereview.appspot.com/6601056