Issue 6600044: code review 6600044: cmd/gc: track parameter flow, step 0: synthesize name n...

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Issue 6600044: code review 6600044: cmd/gc: track parameter flow, step 0: synthesize name n... (Closed)

Can't Edit
Can't Publish+Mail
Start Review

Created:
12 years ago by lvd

Modified:
11 years, 12 months ago

Reviewers:

CC:
rsc, golang-dev

Visibility:
Public.

Description

cmd/gc: track parameter flow, step 0: synthesize name nodes for anonymous PPARAMOUTs without breaking anything. further work on parameter flow tracking for escape analysis depends on this.

Patch Set 2 : diff -r dfb1b5655e21 https://go.googlecode.com/hg/ #

Patch Set 3 : diff -r dfb1b5655e21 https://go.googlecode.com/hg/ #

Patch Set 4 : diff -r dfb1b5655e21 https://go.googlecode.com/hg/ #

Patch Set 5 : diff -r 32c1ce44286f https://go.googlecode.com/hg/ #

Total comments: 3

Patch Set 6 : diff -r d8f98dcc0819 https://go.googlecode.com/hg/ #

Created: 11 years, 12 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+42 lines, -20 lines)			Patch
M	src/cmd/gc/closure.c	View	1 2 3	2 chunks	+5 lines, -2 lines	0 comments	Download
M	src/cmd/gc/dcl.c	View	1 2 3 4 5	3 chunks	+29 lines, -16 lines	0 comments	Download
M	src/cmd/gc/fmt.c	View	1	2 chunks	+8 lines, -2 lines	0 comments	Download

Messages

Total messages: 3

Expand All Messages | Collapse All Messages

lvd

Hello rsc@golang.org (cc: golang-dev@googlegroups.com), I'd like you to review this change to https://go.googlecode.com/hg/

11 years, 12 months ago (2012-10-18 15:57:13 UTC) #1

rsc

LGTM https://codereview.appspot.com/6600044/diff/8001/src/cmd/gc/dcl.c File src/cmd/gc/dcl.c (right): https://codereview.appspot.com/6600044/diff/8001/src/cmd/gc/dcl.c#newcode609 src/cmd/gc/dcl.c:609: // give it a name so escape analysis ...

11 years, 12 months ago (2012-10-21 21:55:59 UTC) #2

lvd

11 years, 12 months ago (2012-10-22 08:09:56 UTC) #3

*** Submitted as http://code.google.com/p/go/source/detail?r=06ac3095d784 ***

cmd/gc: track parameter flow, step 0: synthesize name nodes for anonymous
PPARAMOUTs without breaking anything.

further work on parameter flow tracking for escape analysis depends on this.

R=rsc
CC=golang-dev
http://codereview.appspot.com/6600044

Expand All Messages | Collapse All Messages