Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(651)

Issue 65970043: Minor changes in preparation for release.

Can't Edit
Can't Publish+Mail
Start Review
Created:
11 years, 1 month ago by frankban
Modified:
11 years, 1 month ago
Reviewers:
rharding, mp+207145
Visibility:
Public.

Description

Minor changes in preparation for release. Bump version up to 1.1.0. Re-organize the "requires sudo" code. Restore 100% unit test coverage (compulsive mode on). Update license headers of modified files. Tests: `make check` QA: use quickstart as usual, bootstrapping both ec2 and local environments. https://code.launchpad.net/~frankban/juju-quickstart/prepare-new-release/+merge/207145 (do not edit description out of merge proposal)

Patch Set 1 #

Total comments: 3

Patch Set 2 : Minor changes in preparation for release. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+98 lines, -71 lines) Patch
M HACKING.rst View 1 1 chunk +5 lines, -0 lines 0 comments Download
A [revision details] View 1 1 chunk +2 lines, -0 lines 0 comments Download
M quickstart/__init__.py View 2 chunks +2 lines, -2 lines 0 comments Download
M quickstart/app.py View 3 chunks +22 lines, -2 lines 0 comments Download
M quickstart/manage.py View 2 chunks +2 lines, -11 lines 0 comments Download
M quickstart/settings.py View 2 chunks +3 lines, -3 lines 0 comments Download
M quickstart/tests/test_app.py View 3 chunks +52 lines, -5 lines 0 comments Download
M quickstart/tests/test_manage.py View 5 chunks +8 lines, -14 lines 0 comments Download
M quickstart/tests/test_utils.py View 2 chunks +1 line, -24 lines 0 comments Download
M quickstart/utils.py View 2 chunks +1 line, -10 lines 0 comments Download

Messages

Total messages: 5
frankban
Please take a look.
11 years, 1 month ago (2014-02-19 11:55:47 UTC) #1
rharding
LGTM with the one note on potential room for a docs update. Will QA. https://codereview.appspot.com/65970043/diff/1/quickstart/manage.py ...
11 years, 1 month ago (2014-02-19 13:29:08 UTC) #2
rharding
QA ok
11 years, 1 month ago (2014-02-19 13:52:33 UTC) #3
frankban
*** Submitted: Minor changes in preparation for release. Bump version up to 1.1.0. Re-organize the ...
11 years, 1 month ago (2014-02-19 13:57:42 UTC) #4
frankban
11 years, 1 month ago (2014-02-19 13:59:36 UTC) #5
Thank you!
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld f62528b