Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(1332)

Issue 6596048: server: move non-servery bits to hook

Can't Edit
Can't Publish+Mail
Start Review
Created:
11 years, 7 months ago by fwereade
Modified:
11 years, 7 months ago
Reviewers:
mp+127227, rog
Visibility:
Public.

Description

server: move non-servery bits to hook NOTE: CRACK. Most of it still needs to move, but hook isn't quite the right place. Working out where it should really go before proposing. The only remaining bit of server is Server; the contexts and commands have moved to hook, and HookContext became plain Context, while other names were left as-is. I am almost entirely certain that more steps will be required after this before we hit on the right place/name/shape for everything, but I am also confident that this is a step in a good direction. https://code.launchpad.net/~fwereade/juju-core/move-hook-context/+merge/127227 (do not edit description out of merge proposal)

Patch Set 1 #

Patch Set 2 : server: move non-servery bits to hook #

Unified diffs Side-by-side diffs Delta from patch set Stats (+153 lines, -154 lines) Patch
A [revision details] View 1 chunk +2 lines, -0 lines 0 comments Download
M cmd/jujuc/server/server_test.go View 1 chunk +6 lines, -0 lines 0 comments Download
M worker/uniter/hook/config-get.go View 2 chunks +4 lines, -4 lines 0 comments Download
M worker/uniter/hook/config-get_test.go View 6 chunks +7 lines, -7 lines 0 comments Download
M worker/uniter/hook/context.go View 10 chunks +13 lines, -16 lines 0 comments Download
M worker/uniter/hook/context_test.go View 12 chunks +14 lines, -14 lines 0 comments Download
M worker/uniter/hook/hook_test.go View 1 chunk +3 lines, -2 lines 0 comments Download
M worker/uniter/hook/juju-log.go View 2 chunks +4 lines, -4 lines 0 comments Download
M worker/uniter/hook/juju-log_test.go View 4 chunks +7 lines, -7 lines 0 comments Download
M worker/uniter/hook/ports.go View 4 chunks +8 lines, -8 lines 0 comments Download
M worker/uniter/hook/ports_test.go View 5 chunks +5 lines, -5 lines 0 comments Download
M worker/uniter/hook/relation-get.go View 2 chunks +4 lines, -4 lines 0 comments Download
M worker/uniter/hook/relation-get_test.go View 5 chunks +8 lines, -8 lines 0 comments Download
M worker/uniter/hook/relation-ids.go View 2 chunks +4 lines, -4 lines 0 comments Download
M worker/uniter/hook/relation-ids_test.go View 6 chunks +9 lines, -9 lines 0 comments Download
M worker/uniter/hook/relation-list.go View 2 chunks +4 lines, -4 lines 0 comments Download
M worker/uniter/hook/relation-list_test.go View 4 chunks +7 lines, -7 lines 0 comments Download
M worker/uniter/hook/relation-set.go View 2 chunks +4 lines, -4 lines 0 comments Download
M worker/uniter/hook/relation-set_test.go View 5 chunks +8 lines, -8 lines 0 comments Download
M worker/uniter/hook/unit-get.go View 2 chunks +4 lines, -4 lines 0 comments Download
M worker/uniter/hook/unit-get_test.go View 7 chunks +8 lines, -8 lines 0 comments Download
M worker/uniter/hook/util_test.go View 6 chunks +11 lines, -17 lines 0 comments Download
M worker/uniter/relationer.go View 5 chunks +4 lines, -5 lines 0 comments Download
M worker/uniter/tools.go View 2 chunks +2 lines, -2 lines 0 comments Download
M worker/uniter/tools_test.go View 2 chunks +2 lines, -2 lines 0 comments Download
M worker/uniter/uniter.go View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 2
fwereade
Please take a look.
11 years, 7 months ago (2012-10-01 10:24:34 UTC) #1
rog
11 years, 7 months ago (2012-10-01 10:58:49 UTC) #2
On 2012/10/01 10:24:34, fwereade wrote:
> Please take a look.

LGTM. hook.Context seems right.
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld f62528b