Issue 65950044: code review 65950044: cmd/pack: use log.SetPrefix to make log calls more comp...

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Issue 65950044: code review 65950044: cmd/pack: use log.SetPrefix to make log calls more comp... (Closed)

Can't Edit
Can't Publish+Mail
Start Review

Created:
11 years, 4 months ago by r

Modified:
11 years, 4 months ago

Reviewers:
gobot, rsc

CC:
rsc, golang-codereviews

Visibility:
Public.

cmd/pack: use log.SetPrefix to make log calls more compact and consistent Taking my own advice from a review of addr2line.

Created: 11 years, 4 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+18 lines, -17 lines)			Patch
	M	src/cmd/pack/pack.go	View		11 chunks	+18 lines, -17 lines	0 comments	Download

Total messages: 4

Hello rsc (cc: golang-codereviews@googlegroups.com), I'd like you to review this change to https://code.google.com/p/go

11 years, 4 months ago (2014-02-19 19:38:24 UTC) #1

*** Submitted as https://code.google.com/p/go/source/detail?r=ea795573aef0 *** cmd/pack: use log.SetPrefix to make log calls more compact and ...

11 years, 4 months ago (2014-02-19 19:41:24 UTC) #3

gobot

11 years, 4 months ago (2014-02-19 20:59:09 UTC) #4

Message was sent while issue was closed.

This CL appears to have broken the linux-amd64-race builder.