Issue 6591080: cmd/jujuc: config-get: return default values

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Issue 6591080: cmd/jujuc: config-get: return default values (Closed)

Can't Edit
Can't Publish+Mail
Start Review

Created:
11 years, 6 months ago by dfc

Modified:
11 years, 6 months ago

Reviewers:
mp+127981

Visibility:
Public.

Description

cmd/jujuc: config-get: return default values As discussed on IRC, this proposal is not the solution to the complex issue of versioned configuration settings. It is not even a start. However with this patch in place I am able to get charms running on ec2 and fix integration issues. https://code.launchpad.net/~dave-cheney/juju-core/012-cmd-jujuc-config-get/+merge/127981 (do not edit description out of merge proposal)

Patch Set 1 #

Patch Set 2 : cmd/jujuc: config-get: return default values #

Total comments: 2

Patch Set 3 : cmd/jujuc: config-get: return default values #

Created: 11 years, 6 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+26 lines, -4 lines)			Patch
A	[revision details]	View	1 2	1 chunk	+2 lines, -0 lines	0 comments	Download
M	worker/uniter/jujuc/config-get.go	View	1 2	1 chunk	+21 lines, -2 lines	0 comments	Download
M	worker/uniter/jujuc/config-get_test.go	View	1 2	2 chunks	+3 lines, -2 lines	0 comments	Download

Messages

Total messages: 3

Expand All Messages | Collapse All Messages

niemeyer

LGTM https://codereview.appspot.com/6591080/diff/2001/cmd/jujuc/server/config-get.go File cmd/jujuc/server/config-get.go (right): https://codereview.appspot.com/6591080/diff/2001/cmd/jujuc/server/config-get.go#newcode44 cmd/jujuc/server/config-get.go:44: } // TODO Remove this once state is ...

11 years, 6 months ago (2012-10-04 21:03:45 UTC) #2

dfc

11 years, 6 months ago (2012-10-04 23:45:15 UTC) #3

*** Submitted:

cmd/jujuc: config-get: return default values

As discussed on IRC, this proposal is not the solution to the complex issue of
versioned configuration settings. It is not even a start. However with this
patch in place I am able to get charms running on ec2 and fix integration
issues.

R=niemeyer
CC=
https://codereview.appspot.com/6591080

https://codereview.appspot.com/6591080/diff/2001/cmd/jujuc/server/config-get.go
File cmd/jujuc/server/config-get.go (right):

https://codereview.appspot.com/6591080/diff/2001/cmd/jujuc/server/config-get....
cmd/jujuc/server/config-get.go:44: }
On 2012/10/04 21:03:45, niemeyer wrote:
> // TODO Remove this once state is fixed to report default values.

Done.

Expand All Messages | Collapse All Messages