Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(1101)

Issue 6590064: state: fix tests (Closed)

Can't Edit
Can't Publish+Mail
Start Review
Created:
11 years, 7 months ago by dave
Modified:
11 years, 7 months ago
Reviewers:
mp+127611
Visibility:
Public.

Description

state: fix tests Test fixtures needed to be updated with a firewall-mode configuration option. https://code.launchpad.net/~dave-cheney/juju-core/010-state-fix-missing-firewall-mode-configuration/+merge/127611 (do not edit description out of merge proposal)

Patch Set 1 #

Patch Set 2 : state: fix tests #

Unified diffs Side-by-side diffs Delta from patch set Stats (+6 lines, -0 lines) Patch
A [revision details] View 1 chunk +2 lines, -0 lines 0 comments Download
M state/state_test.go View 4 chunks +4 lines, -0 lines 0 comments Download

Messages

Total messages: 3
dave_cheney.net
Please take a look.
11 years, 7 months ago (2012-10-02 23:13:02 UTC) #1
niemeyer
LGTM
11 years, 7 months ago (2012-10-02 23:14:05 UTC) #2
dave_cheney.net
11 years, 7 months ago (2012-10-02 23:16:09 UTC) #3
*** Submitted:

state: fix tests

Test fixtures needed to be updated with a firewall-mode configuration option.

R=niemeyer
CC=
https://codereview.appspot.com/6590064
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld f62528b