ec2: integrated firewall mode configuration

ec2: integrated firewall mode configuration

After the adding of a configuration switch for default
or global firewall mode this behavior is now integrated
in EC2. If the mode is "global", then instead of a group 
per machine one group "juju-<name>-global" is created
additionally to the juju group. All machines share this
global group then and opening and closing ports on it
so effect all machines.

https://code.launchpad.net/~themue/juju-core/go-ec2-firewall-mode/+merge/128027

(do not edit description out of merge proposal)

[TheMue, 2012-10-04 14:29:29]

Please take a look.

[niemeyer, 2012-10-04 15:45:13]

The logic looks very pleasing, but the testing doesn't look very clear. When is
the "global" environment ever run, and will we repeat all the tests just to
verify that one aspect?

It'd be better to have a test that covers that one specific aspect in a very
obvious and terse way instead.

Do you have any ideas for how we could put that in place?

[TheMue, 2012-10-04 19:24:48]

Yes, the testing is really not beautiful and is driven by the two environments
in the configuration. So yes, the tests run twice, because the way the tests
work generates two suite instances per environment.

I'll see how I can extract it in two standalone tests, one with mode = default
and one with mode = global.

[niemeyer, 2012-10-04 20:17:23]

On 2012/10/04 19:24:48, TheMue wrote:
> Yes, the testing is really not beautiful and is driven by the two environments
> in the configuration. So yes, the tests run twice, because the way the tests
> work generates two suite instances per environment.
> 
> I'll see how I can extract it in two standalone tests, one with mode = default
> and one with mode = global.

I don't think we need two environments. This is just a setting of the
environment that can be changed at will. We need one single test that verifies
the specific differences of FwGlobal, and nothing else.

[TheMue, 2012-10-05 08:41:39]

Please take a look.

[TheMue, 2012-10-05 14:13:21]

Please take a look.

[niemeyer, 2012-10-05 14:22:46]

LGTM assuming that live tests pass with -amazon.

https://codereview.appspot.com/6589073/diff/6001/environs/jujutest/livetests.go
File environs/jujutest/livetests.go (right):

https://codereview.appspot.com/6589073/diff/6001/environs/jujutest/livetests....
environs/jujutest/livetests.go:146: 
I believe you need to call BootstrapOnce. It's probably working due to the
ordering of tests.

https://codereview.appspot.com/6589073/diff/6001/environs/jujutest/livetests....
environs/jujutest/livetests.go:161: 
s/checkopen/check open/

https://codereview.appspot.com/6589073/diff/6001/environs/jujutest/livetests....
environs/jujutest/livetests.go:164: 
d

This isn't the place to test that StartInstance works. If it returned no error,
its contract says it has to return an instance.

https://codereview.appspot.com/6589073/diff/6001/environs/jujutest/livetests....
environs/jujutest/livetests.go:172: 
d

[TheMue, 2012-10-05 15:38:10]

*** Submitted:

ec2: integrated firewall mode configuration

After the adding of a configuration switch for default
or global firewall mode this behavior is now integrated
in EC2. If the mode is "global", then instead of a group 
per machine one group "juju-<name>-global" is created
additionally to the juju group. All machines share this
global group then and opening and closing ports on it
so effect all machines.

R=niemeyer
CC=
https://codereview.appspot.com/6589073