Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(3400)

Issue 6589056: Exceptions for hook commands using relation id

Can't Edit
Can't Publish+Mail
Start Review
Created:
11 years, 7 months ago by jimbaker
Modified:
11 years, 7 months ago
Reviewers:
mp+127188
Visibility:
Public.

Description

Exceptions for hook commands using relation id AMP requires that all exceptions that are passed between the hook command (client) and unit agent (server) are registered, otherwise it will raise "twisted ERROR: Unhandled Error". This branch fixes this issue for exceptions introduced by the use of -r to specify a relation id. In addition for completeness, other tests were added around potential error cases. This branch also resolves bug #1050592, which saw this issue in the use of relation-list with -r. Note that these fixes continue the current practice that an error report is written to stderr ("Relation not found"), but the exit code of the hook command is still 0. I have tested the branch with the the debug-charm attached to the bug, lp:~mew/+junk/debug-charm https://code.launchpad.net/~jimbaker/juju/hook-command-error-cases/+merge/127188 (do not edit description out of merge proposal)

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+294 lines, -33 lines) Patch
A [revision details] View 1 chunk +2 lines, -0 lines 0 comments Download
M juju/hooks/commands.py View 4 chunks +36 lines, -10 lines 0 comments Download
M juju/hooks/invoker.py View 2 chunks +6 lines, -2 lines 0 comments Download
M juju/hooks/protocol.py View 2 chunks +11 lines, -6 lines 0 comments Download
M juju/hooks/tests/test_invoker.py View 8 chunks +239 lines, -15 lines 0 comments Download

Messages

Total messages: 1
jimbaker
11 years, 7 months ago (2012-10-02 14:46:02 UTC) #1
Please take a look.
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld f62528b