Issue 6587085: environs/config: add admin-secret attribute

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Issue 6587085: environs/config: add admin-secret attribute

Can't Edit
Can't Publish+Mail
Start Review

Created:
11 years, 6 months ago by rog

Modified:
11 years, 6 months ago

Reviewers:
mp+128034

Visibility:
Public.

Description

environs/config: add admin-secret attribute https://code.launchpad.net/~rogpeppe/juju-core/104-config-admin-secret/+merge/128034 Requires: https://code.launchpad.net/~rogpeppe/juju-core/103-jujud-initial-password/+merge/127950 (do not edit description out of merge proposal)

Patch Set 1 #

Patch Set 2 : environs/config: add admin-secret attribute #

Total comments: 3

Patch Set 3 : environs/config: add admin-secret attribute #

Patch Set 4 : environs/config: add admin-secret attribute #

Created: 11 years, 6 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+77 lines, -3 lines)			Patch
A	[revision details]	View	1 2 3	1 chunk	+2 lines, -0 lines	0 comments	Download
M	environs/config.go	View		1 chunk	+2 lines, -0 lines	0 comments	Download
M	environs/config/config.go	View		3 chunks	+8 lines, -0 lines	0 comments	Download
M	environs/config/config_test.go	View		3 chunks	+10 lines, -0 lines	0 comments	Download
M	environs/config_test.go	View		3 chunks	+33 lines, -3 lines	0 comments	Download
M	state/state.go	View		1 chunk	+3 lines, -0 lines	0 comments	Download
M	state/state_test.go	View	1 2 3	5 chunks	+19 lines, -0 lines	0 comments	Download

Messages

Total messages: 3

Expand All Messages | Collapse All Messages

niemeyer

That's great. LGTM. https://codereview.appspot.com/6587085/diff/2001/environs/config/config_test.go File environs/config/config_test.go (right): https://codereview.appspot.com/6587085/diff/2001/environs/config/config_test.go#newcode215 environs/config/config_test.go:215: c.Assert(cfg.FirewallMode(), Equals, config.FirewallMode(m)) Thanks. https://codereview.appspot.com/6587085/diff/2001/state/state_test.go File ...

11 years, 6 months ago (2012-10-04 15:38:06 UTC) #2

rog

11 years, 6 months ago (2012-10-04 15:48:24 UTC) #3

*** Submitted:

environs/config: add admin-secret attribute

R=niemeyer
CC=
https://codereview.appspot.com/6587085

https://codereview.appspot.com/6587085/diff/2001/state/state_test.go
File state/state_test.go (right):

https://codereview.appspot.com/6587085/diff/2001/state/state_test.go#newcode268
state/state_test.go:268: c.Assert(err, ErrorMatches, "admin-secret should never
be written to the state")
On 2012/10/04 15:38:06, niemeyer wrote:
> Would be great to have this on its own TestEnvironConfigWithAdminSecret.

Done.

Expand All Messages | Collapse All Messages