Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(242)

Issue 65870044: code review 65870044: cmd/ld: drop gcargs, gclocals symbols from symbol table (Closed)

Can't Edit
Can't Publish+Mail
Start Review
Created:
7 years, 11 months ago by rsc
Modified:
7 years, 11 months ago
Reviewers:
r, gobot
CC:
r, golang-codereviews
Visibility:
Public.

Description

cmd/ld: drop gcargs, gclocals symbols from symbol table Update issue 6853 Every function now has a gcargs and gclocals symbol holding associated garbage collection information. Put them all in the same meta-symbol as the go.func data and then drop individual entries from symbol table. Removing gcargs and gclocals reduces the size of a typical binary by 10%.

Patch Set 1 #

Patch Set 2 : diff -r 737767dd81fd https://code.google.com/p/go/ #

Patch Set 3 : diff -r 737767dd81fd https://code.google.com/p/go/ #

Patch Set 4 : diff -r 2d7f9200c267 https://code.google.com/p/go/ #

Unified diffs Side-by-side diffs Delta from patch set Stats (+5 lines, -0 lines) Patch
M src/cmd/ld/symtab.c View 1 1 chunk +5 lines, -0 lines 0 comments Download

Messages

Total messages: 4
rsc
Hello r (cc: golang-codereviews@googlegroups.com), I'd like you to review this change to https://code.google.com/p/go/
7 years, 11 months ago (2014-02-19 05:02:57 UTC) #1
r
LGTM again, update issue 6853
7 years, 11 months ago (2014-02-19 06:37:12 UTC) #2
rsc
*** Submitted as https://code.google.com/p/go/source/detail?r=1b09c63ca02a *** cmd/ld: drop gcargs, gclocals symbols from symbol table Update issue ...
7 years, 11 months ago (2014-02-19 15:00:47 UTC) #3
gobot
7 years, 11 months ago (2014-02-20 12:55:44 UTC) #4
Message was sent while issue was closed.
This CL appears to have broken the linux-arm-cheney-panda builder.
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld f62528b