state: add SetAdminPassword

state: add SetAdminPassword

We also run the testing mongo in auth mode to make sure
that it's working. Next up: passwords for entities.

We don't include SetAdminPassword as part of state.Initialize
because otherwise all the testing stuff breaks - there
are several places (for instance testing.MgoReset) which assume
we can connect to the state at will without authorisation.

For the above reason we provide the capability to turn
off authorization (an empty password passed to SetAdminPassword);
we could provide an extra call to do that if it was deemed better.

https://code.launchpad.net/~rogpeppe/juju-core/102-mongo-auth-mode/+merge/127750

(do not edit description out of merge proposal)

[rog, 2012-10-03 13:05:29]

Please take a look.

[niemeyer, 2012-10-03 13:22:32]

Looks sane. A couple of minors:

https://codereview.appspot.com/6586070/diff/2001/state/state_test.go
File state/state_test.go (right):

https://codereview.appspot.com/6586070/diff/2001/state/state_test.go#newcode885
state/state_test.go:885: func (s *StateSuite) TestSetAdminPassword(c *C) {
defer s.State.SetAdminPassword("")?

Otherwise if this fails everything else will likely be locked out of the
database.

https://codereview.appspot.com/6586070/diff/2001/state/state_test.go#newcode893
state/state_test.go:893: c.Assert(err, ErrorMatches, "cannot create log
collection: unauthorized db.*")
That's not a great check. It's relying on internal details of the implementation
which will certainly change and break this test, even if the feature that is
being tested here isn't broken.

I suspect that trying to read from the database, such as with
s.State.Service("foo"), might break more reliably.

[rog, 2012-10-03 13:44:35]

Please take a look.

https://codereview.appspot.com/6586070/diff/2001/state/state_test.go
File state/state_test.go (right):

https://codereview.appspot.com/6586070/diff/2001/state/state_test.go#newcode885
state/state_test.go:885: func (s *StateSuite) TestSetAdminPassword(c *C) {
On 2012/10/03 13:22:32, niemeyer wrote:
> defer s.State.SetAdminPassword("")?
> 
> Otherwise if this fails everything else will likely be locked out of the
> database.

Done.

https://codereview.appspot.com/6586070/diff/2001/state/state_test.go#newcode893
state/state_test.go:893: c.Assert(err, ErrorMatches, "cannot create log
collection: unauthorized db.*")
On 2012/10/03 13:22:32, niemeyer wrote:
> That's not a great check. It's relying on internal details of the
implementation
> which will certainly change and break this test, even if the feature that is
> being tested here isn't broken.
> 
> I suspect that trying to read from the database, such as with
> s.State.Service("foo"), might break more reliably.

fixed as discussed on line.

[niemeyer, 2012-10-03 13:52:57]

https://codereview.appspot.com/6586070/diff/6001/state/state_test.go
File state/state_test.go (right):

https://codereview.appspot.com/6586070/diff/6001/state/state_test.go#newcode894
state/state_test.go:894: c.Assert(err, ErrorMatches, "unauthorized access to
database")
"unauthorized access"

Someone adding admin-secret to the configuration won't know that this is a
password to the database.

[niemeyer, 2012-10-03 13:53:19]

LGTM with the trivial.

[rog, 2012-10-03 16:30:09]

*** Submitted:

state: add SetAdminPassword

We also run the testing mongo in auth mode to make sure
that it's working. Next up: passwords for entities.

We don't include SetAdminPassword as part of state.Initialize
because otherwise all the testing stuff breaks - there
are several places (for instance testing.MgoReset) which assume
we can connect to the state at will without authorisation.

For the above reason we provide the capability to turn
off authorization (an empty password passed to SetAdminPassword);
we could provide an extra call to do that if it was deemed better.

R=niemeyer
CC=
https://codereview.appspot.com/6586070