Detect error page from SharePoint

Detect error page from SharePoint

[ejona, 2014-02-19 17:56:42]

https://codereview.appspot.com/65800043/diff/1/src/com/google/enterprise/adap...
File src/com/google/enterprise/adaptor/sharepoint/SharePointAdaptor.java
(right):

https://codereview.appspot.com/65800043/diff/1/src/com/google/enterprise/adap...
src/com/google/enterprise/adaptor/sharepoint/SharePointAdaptor.java:2500: if
(!Strings.isNullOrEmpty(errorHeader)) {
I'm fine with just checking for null. If it is empty, they are doing something
strange, and I'm not sure we shouldn't throw an exception in that case.

https://codereview.appspot.com/65800043/diff/1/src/com/google/enterprise/adap...
src/com/google/enterprise/adaptor/sharepoint/SharePointAdaptor.java:2503: , new
Object[] {errorHeader, url});
Comma should always be part of the previous line, as much as that is painful in
this case.

https://codereview.appspot.com/65800043/diff/1/src/com/google/enterprise/adap...
src/com/google/enterprise/adaptor/sharepoint/SharePointAdaptor.java:2509: throw
new IOException("Error on SharePoint for URL " + url);
Include the error code.

https://codereview.appspot.com/65800043/diff/1/src/com/google/enterprise/adap...
src/com/google/enterprise/adaptor/sharepoint/SharePointAdaptor.java:2509: throw
new IOException("Error on SharePoint for URL " + url);
We shouldn't log a warning and throw an exception; we should only do one or the
other. Just throw an exception with the appropriate description based on the
case.

[ejona, 2014-02-19 20:39:08]

LGTM

[Tanmay Vartak, 2014-02-19 22:14:00]

On 2014/02/19 20:39:08, ejona wrote:
> LGTM

Code Commit:
https://code.google.com/p/plexi/source/detail?r=9d1e7ae0ec0bfad183dca8b12c1cd...