Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(1755)

Issue 65790043: Fix UNIX domain warnings

Can't Edit
Can't Publish+Mail
Start Review
Created:
10 years, 2 months ago by haypo_gmail
Modified:
10 years, 2 months ago
Reviewers:
yselivanov, GvR
Visibility:
Public.

Description

Fix UNIX domain warnings

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+19 lines, -17 lines) Patch
M asyncio/unix_events.py View 2 chunks +4 lines, -4 lines 0 comments Download
M tests/test_unix_events.py View 3 chunks +15 lines, -13 lines 0 comments Download

Messages

Total messages: 5
yselivanov
Changes look good to me. The only question is: I modelled 'create_unix_server' closely after 'create_server', ...
10 years, 2 months ago (2014-02-19 00:28:33 UTC) #1
yselivanov
"should have the same exceptions" --> "should have the same shortcomings"
10 years, 2 months ago (2014-02-19 00:30:03 UTC) #2
haypo_gmail
On 2014/02/19 00:28:33, yselivanov wrote: > Changes look good to me. > > The only ...
10 years, 2 months ago (2014-02-19 00:31:48 UTC) #3
yselivanov
On 2014/02/19 00:31:48, haypo_gmail wrote: > On 2014/02/19 00:28:33, yselivanov wrote: > > Changes look ...
10 years, 2 months ago (2014-02-19 00:38:17 UTC) #4
GvR
10 years, 2 months ago (2014-02-19 00:38:19 UTC) #5
Do you guys need my help on this? I don't think so -- once you agree on a patch
go ahead and commit without waiting for me.
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld f62528b