Changes look good to me. The only question is: I modelled 'create_unix_server' closely after 'create_server', ...
10 years, 2 months ago
(2014-02-19 00:28:33 UTC)
#1
Changes look good to me.
The only question is: I modelled 'create_unix_server' closely after
'create_server', hence the latter should have the same exceptions. Could you
please apply the same refactoring there?
On 2014/02/19 00:28:33, yselivanov wrote: > Changes look good to me. > > The only ...
10 years, 2 months ago
(2014-02-19 00:31:48 UTC)
#3
On 2014/02/19 00:28:33, yselivanov wrote:
> Changes look good to me.
>
> The only question is: I modelled 'create_unix_server' closely after
> 'create_server', hence the latter should have the same exceptions. Could you
> please apply the same refactoring there?
create_server() has a different design, it has a try/finally protection almost
the whole method. Are you sure that it has the same bug? I cannot see it.
On 2014/02/19 00:31:48, haypo_gmail wrote: > On 2014/02/19 00:28:33, yselivanov wrote: > > Changes look ...
10 years, 2 months ago
(2014-02-19 00:38:17 UTC)
#4
On 2014/02/19 00:31:48, haypo_gmail wrote:
> On 2014/02/19 00:28:33, yselivanov wrote:
> > Changes look good to me.
> >
> > The only question is: I modelled 'create_unix_server' closely after
> > 'create_server', hence the latter should have the same exceptions. Could you
> > please apply the same refactoring there?
>
> create_server() has a different design, it has a try/finally protection almost
> the whole method. Are you sure that it has the same bug? I cannot see it.
You're right.
The patch is LGTM
Issue 65790043: Fix UNIX domain warnings
Created 10 years, 2 months ago by haypo_gmail
Modified 10 years, 2 months ago
Reviewers: yselivanov, GvR
Base URL:
Comments: 0