Issue 6574060: cmd/jujud: allow for a clean exit

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Issue 6574060: cmd/jujud: allow for a clean exit

Can't Edit
Can't Publish+Mail
Start Review

Created:
12 years, 5 months ago by rog

Modified:
12 years, 5 months ago

Reviewers:
mp+126998

Visibility:
Public.

Description

cmd/jujud: allow for a clean exit When a unit or a machine dies, we want the unit or machine agent to exit cleanly, so prepare for the worker to return ErrDead in that case, and exit cleanly when the unit or machine is dead to start with. Reviewed at https://codereview.appspot.com/6567067/. https://code.launchpad.net/~rogpeppe/juju-core/093-jujud-lifecycle/+merge/126998 (do not edit description out of merge proposal)

Patch Set 1 #

Patch Set 2 : cmd/jujud: allow for a clean exit #

Created: 12 years, 5 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+196 lines, -80 lines)			Patch
A	[revision details]	View	1 chunk	+2 lines, -0 lines	0 comments	Download
M	cmd/jujud/machine.go	View	4 chunks	+14 lines, -1 line	0 comments	Download
M	cmd/jujud/machine_test.go	View	1 chunk	+29 lines, -0 lines	0 comments	Download
M	cmd/jujud/unit.go	View	3 chunks	+8 lines, -0 lines	0 comments	Download
M	cmd/jujud/unit_test.go	View	3 chunks	+85 lines, -28 lines	0 comments	Download
M	cmd/jujud/upgrade_test.go	View	9 chunks	+52 lines, -51 lines	0 comments	Download
M	upstart/upstart.go	View	2 chunks	+2 lines, -0 lines	0 comments	Download
M	upstart/upstart_test.go	View	1 chunk	+1 line, -0 lines	0 comments	Download
M	worker/environ.go	View	2 chunks	+3 lines, -0 lines	0 comments	Download

Messages

Total messages: 1

Expand All Messages | Collapse All Messages

rog

12 years, 5 months ago (2012-09-28 15:42:21 UTC) #1

*** Submitted:

cmd/jujud: allow for a clean exit

When a unit or a machine dies, we want the
unit or machine agent to exit cleanly, so
prepare for the worker to return ErrDead in that
case, and exit cleanly when the unit or machine
is dead to start with.

Reviewed at https://codereview.appspot.com/6567067/.

R=
CC=
https://codereview.appspot.com/6574060

Expand All Messages | Collapse All Messages