Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(1949)

Issue 6574049: environs: merge args and log cmd name on build

Can't Edit
Can't Publish+Mail
Start Review
Created:
10 years, 2 months ago by niemeyer
Modified:
10 years, 2 months ago
Reviewers:
mp+126485, fwereade
Visibility:
Public.

Description

environs: merge args and log cmd name on build Review from Roger on the previous branch. https://code.launchpad.net/~niemeyer/juju-core/rog-tools-changes-review/+merge/126485 (do not edit description out of merge proposal)

Patch Set 1 #

Patch Set 2 : environs: merge args and log cmd name on build #

Unified diffs Side-by-side diffs Delta from patch set Stats (+6 lines, -6 lines) Patch
A [revision details] View 1 chunk +2 lines, -0 lines 0 comments Download
M environs/tools.go View 2 chunks +3 lines, -5 lines 0 comments Download
M environs/tools_test.go View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 3
niemeyer
Please take a look.
10 years, 2 months ago (2012-09-26 15:47:28 UTC) #1
fwereade
LGTM
10 years, 2 months ago (2012-09-26 20:59:21 UTC) #2
niemeyer
10 years, 2 months ago (2012-09-26 23:08:28 UTC) #3
*** Submitted:

environs: merge args and log cmd name on build

Review from Roger on the previous branch.

R=fwereade
CC=
https://codereview.appspot.com/6574049
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld f62528b