Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(316)

Issue 65740045: code review 65740045: cmd/ld: remove Plan 9 symbol table (Closed)

Can't Edit
Can't Publish+Mail
Start Review
Created:
7 years, 11 months ago by rsc
Modified:
7 years, 11 months ago
Reviewers:
minux1, aram, r, dfc
CC:
r, bradfitz, golang-codereviews
Visibility:
Public.

Description

cmd/ld: remove Plan 9 symbol table Update issue 6853 Nothing reads the Plan 9 symbol table anymore. The last holdout was 'go tool nm', but since being rewritten in Go it uses the standard symbol table for the binary format (ELF, Mach-O, PE) instead. Removing the Plan 9 symbol table saves ~15% disk space on most binaries. Two supporting changes included in this CL: debug/gosym: use Go 1.2 pclntab to synthesize func-only symbol table when there is no Plan 9 symbol table debug/elf, debug/macho, debug/pe: ignore final EOF from ReadAt

Patch Set 1 #

Patch Set 2 : diff -r 63af41fd1829 https://code.google.com/p/go/ #

Patch Set 3 : diff -r 63af41fd1829 https://code.google.com/p/go/ #

Patch Set 4 : diff -r 60fe37dc47e2 https://code.google.com/p/go/ #

Unified diffs Side-by-side diffs Delta from patch set Stats (+46 lines, -170 lines) Patch
M src/cmd/ld/symtab.c View 1 3 chunks +0 lines, -170 lines 0 comments Download
M src/pkg/debug/elf/file.go View 1 1 chunk +3 lines, -0 lines 0 comments Download
M src/pkg/debug/gosym/pclntab.go View 1 1 chunk +27 lines, -0 lines 0 comments Download
M src/pkg/debug/gosym/symtab.go View 1 2 chunks +7 lines, -0 lines 0 comments Download
M src/pkg/debug/macho/file.go View 1 2 chunks +6 lines, -0 lines 0 comments Download
M src/pkg/debug/pe/file.go View 1 1 chunk +3 lines, -0 lines 0 comments Download

Messages

Total messages: 12
rsc
Hello r (cc: golang-codereviews@googlegroups.com), I'd like you to review this change to https://code.google.com/p/go/
7 years, 11 months ago (2014-02-19 03:48:08 UTC) #1
r
LGTM yay update issue 6853
7 years, 11 months ago (2014-02-19 03:51:14 UTC) #2
bradfitz
Yay indeed. On Tue, Feb 18, 2014 at 7:48 PM, <rsc@golang.org> wrote: > Reviewers: r, ...
7 years, 11 months ago (2014-02-19 03:57:04 UTC) #3
rsc
FWIW, also saves 9 seconds on all.bash (5%). Russ
7 years, 11 months ago (2014-02-19 04:38:00 UTC) #4
r
That's not nothing.
7 years, 11 months ago (2014-02-19 04:39:50 UTC) #5
rsc
*** Submitted as https://code.google.com/p/go/source/detail?r=737767dd81fd *** cmd/ld: remove Plan 9 symbol table Update issue 6853 Nothing ...
7 years, 11 months ago (2014-02-19 04:41:19 UTC) #6
dfc
The arm builders count time in dog years, that is more than a minute in ...
7 years, 11 months ago (2014-02-19 04:41:57 UTC) #7
minux1
Both the time and space save are great! Thank you.
7 years, 11 months ago (2014-02-19 04:42:14 UTC) #8
bradfitz
I see a 25% reduction: Before: -rwxr-xr-x 1 bradfitz staff 23556028 Feb 18 20:47 bin/camlistored ...
7 years, 11 months ago (2014-02-19 04:50:25 UTC) #9
aram
Will this break acid symbols in Plan 9?
7 years, 11 months ago (2014-02-19 05:05:38 UTC) #10
rsc
On Wed, Feb 19, 2014 at 12:05 AM, <aram@mgk.ro> wrote: > Will this break acid ...
7 years, 11 months ago (2014-02-19 05:13:37 UTC) #11
aram
7 years, 11 months ago (2014-02-19 05:15:02 UTC) #12
Thank you.
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld f62528b