Refactor of local provider to use Cloud Images

Refactor of local provider to use Cloud Images

- Boots a full container with cloud-init each time, No more template container + clone
- Removes upstart job for storage server. Also fixes machine-agent to be killable on destroy-env
- Uses LXC's default networking rather than libvirt. Removes dependency on libvirt entirely.
- Regresses HTTPS apt support for local provider because cloud-init doesn't have a way to make the
distinction.
- Regresses performance for the case where the download is cached. rsync'ing from the debootstrap
is a little faster than extracting the tar.gz. Also we now do a full apt-get upgrade, so all updates
have to be unpacked/configured.

https://code.launchpad.net/~clint-fewbar/juju/local-cloud-img/+merge/126865

(do not edit description out of merge proposal)

[clint.byrum, 2012-09-28 07:09:06]

Please take a look.

[hazmat, 2012-10-05 03:54:07]

this looks great, thanks clint. i'm gonna run through some functional passes in
the morning.

https://codereview.appspot.com/6572064/diff/1/juju/lib/lxc/__init__.py
File juju/lib/lxc/__init__.py (right):

https://codereview.appspot.com/6572064/diff/1/juju/lib/lxc/__init__.py#newcode54
juju/lib/lxc/__init__.py:54: cloud_init_file=None,
cloud init looks like it should be required, not optional from the usage
elsewhere.

https://codereview.appspot.com/6572064/diff/1/juju/machine/tests/test_unit_de...
File juju/machine/tests/test_unit_deployment.py (right):

https://codereview.appspot.com/6572064/diff/1/juju/machine/tests/test_unit_de...
juju/machine/tests/test_unit_deployment.py:22: DATA_DIR =
os.path.join(os.path.abspath(os.path.dirname(__file__)), "data")
this usage has caused issues in the past with coverage reports vs
inspect.getabspath

https://codereview.appspot.com/6572064/diff/1/juju/machine/tests/test_unit_de...
juju/machine/tests/test_unit_deployment.py:354:
self.assertEquals(cloud_init._origin_url, "lp:~juju/foobar")
fwiw we generally frown on private variable access in tests, as its breaking the
api down to test internal details, not worth addressing here.

[hazmat, 2012-10-05 13:50:57]

https://codereview.appspot.com/6572064/diff/1/juju/providers/local/agent.py
File juju/providers/local/agent.py (right):

https://codereview.appspot.com/6572064/diff/1/juju/providers/local/agent.py#n...
juju/providers/local/agent.py:65: "/var/run/juju/%s-machine-agent.zksession" %
juju_unit_namespace]
The session file should be in the data-dir as well.

[clint.byrum, 2012-10-05 14:13:11]

https://codereview.appspot.com/6572064/diff/1/juju/lib/lxc/__init__.py
File juju/lib/lxc/__init__.py (right):

https://codereview.appspot.com/6572064/diff/1/juju/lib/lxc/__init__.py#newcode54
juju/lib/lxc/__init__.py:54: cloud_init_file=None,
On 2012/10/05 03:54:07, hazmat wrote:
> cloud init looks like it should be required, not optional from the usage
> elsewhere.

My thinking here is that as a general purpose library there may be a very
legitimate usage where we just want a stock container, since we can do file
injection on them very easily. I think its worth leaving as optional for that
reason, since it is definitely optional in the underlying tools.

https://codereview.appspot.com/6572064/diff/1/juju/machine/tests/test_unit_de...
File juju/machine/tests/test_unit_deployment.py (right):

https://codereview.appspot.com/6572064/diff/1/juju/machine/tests/test_unit_de...
juju/machine/tests/test_unit_deployment.py:22: DATA_DIR =
os.path.join(os.path.abspath(os.path.dirname(__file__)), "data")
On 2012/10/05 03:54:07, hazmat wrote:
> this usage has caused issues in the past with coverage reports vs
> inspect.getabspath

This was cargo culted from the other 10 places doing it. That said, I found
somewhere to cargo cult using inspect.getabsfile... and have pushed it.

https://codereview.appspot.com/6572064/diff/1/juju/machine/tests/test_unit_de...
juju/machine/tests/test_unit_deployment.py:22: DATA_DIR =
os.path.join(os.path.abspath(os.path.dirname(__file__)), "data")
On 2012/10/05 03:54:07, hazmat wrote:
> this usage has caused issues in the past with coverage reports vs
> inspect.getabspath

Done.

[hazmat, 2012-10-05 15:02:37]

The env passing here doesn't work, as sudo will strip. see this for an
alternative

http://bazaar.launchpad.net/~hazmat/juju/lxc-killpid/view/head:/juju/lib/serv...