code review 65720045: cmd/link: change cloneProg to return the cloned value

cmd/link: change cloneProg to return the cloned value

The code was returning the original value rather than the cloned value
resulting in the tests not being repeatable.

Fixes issue 7111.

[rick, 2014-02-19 01:23:50]

Hello golang-codereviews@googlegroups.com,

I'd like you to review this change to
https://code.google.com/p/go

[bradfitz, 2014-02-19 01:57:58]

LGTM



On Tue, Feb 18, 2014 at 5:23 PM, <rickarnoldjr@gmail.com> wrote:

> Reviewers: golang-codereviews,
>
> Message:
> Hello golang-codereviews@googlegroups.com,
>
> I'd like you to review this change to
> https://code.google.com/p/go
>
>
> Description:
> cmd/link: change cloneProg to return the cloned value
>
> The code was returning the original value rather than the cloned value
> resulting in the tests not being repeatable.
>
> Fixes issue 7111.
>
> Please review this at https://codereview.appspot.com/65720045/
>
> Affected files (+1, -1 lines):
>   M src/cmd/link/prog_test.go
>
>
> Index: src/cmd/link/prog_test.go
> ===================================================================
> --- a/src/cmd/link/prog_test.go
> +++ b/src/cmd/link/prog_test.go
> @@ -112,7 +112,7 @@
>         for i, seg := range p.Segments {
>                 q.Segments[i] = cloneSegment(seg)
>         }
> -       return p
> +       return q
>  }
>
>  // cloneSegment returns a deep copy of seg.
>
>
> --
> You received this message because you are subscribed to the Google Groups
> "golang-codereviews" group.
> To unsubscribe from this group and stop receiving emails from it, send an
> email to golang-codereviews+unsubscribe@googlegroups.com.
> For more options, visit https://groups.google.com/groups/opt_out.
>

[bradfitz, 2014-02-19 01:59:51]

*** Submitted as https://code.google.com/p/go/source/detail?r=4cc450928949 ***

cmd/link: change cloneProg to return the cloned value

The code was returning the original value rather than the cloned value
resulting in the tests not being repeatable.

Fixes issue 7111.

LGTM=bradfitz
R=golang-codereviews, bradfitz
CC=golang-codereviews
https://codereview.appspot.com/65720045

Committer: Brad Fitzpatrick <bradfitz@golang.org>

[gobot, 2014-02-19 02:29:32]

This CL appears to have broken the linux-arm-cheney-panda builder.