Issue 6571053: state: revert machine watcher to return the id

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Issue 6571053: state: revert machine watcher to return the id

Can't Edit
Can't Publish+Mail
Start Review

Created:
11 years, 7 months ago by niemeyer

Modified:
11 years, 7 months ago

Reviewers:
mp+126348, fwereade

Visibility:
Public.

Description

state: revert machine watcher to return the id Ironically, the first test that I went to fix in live tests was using the result of the machine watcher (the machine, now the id) in a meaningful way. This is not the time for that kind of refactoring. https://code.launchpad.net/~niemeyer/juju-core/revert-machine-watcher-return/+merge/126348 (do not edit description out of merge proposal)

Patch Set 1 #

Patch Set 2 : state: revert machine watcher to return the id #

Created: 11 years, 7 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+9 lines, -8 lines)			Patch
A	[revision details]	View	1 chunk	+2 lines, -0 lines	0 comments	Download
M	state/machine_test.go	View	1 chunk	+2 lines, -1 line	0 comments	Download
M	state/watcher.go	View	4 chunks	+5 lines, -7 lines	0 comments	Download

Messages

Total messages: 4

Expand All Messages | Collapse All Messages

niemeyer

11 years, 7 months ago (2012-09-25 23:10:21 UTC) #4

*** Submitted:

state: revert machine watcher to return the id

Ironically, the first test that I went to fix in live tests was using the
result of the machine watcher (the machine, now the id) in a meaningful way.
This is not the time for that kind of refactoring.

R=fwereade
CC=
https://codereview.appspot.com/6571053

Expand All Messages | Collapse All Messages