Issue 6570064: state: add CharmURL() to Service

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Issue 6570064: state: add CharmURL() to Service

Can't Edit
Can't Publish+Mail
Start Review

Created:
11 years, 7 months ago by fwereade

Modified:
11 years, 7 months ago

Reviewers:
mp+127027

Visibility:
Public.

Description

state: add CharmURL() to Service https://code.launchpad.net/~fwereade/juju-core/service-charm-url/+merge/127027 (do not edit description out of merge proposal)

Patch Set 2 : state: add CharmURL() to Service #

Created: 11 years, 7 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+14 lines, -0 lines)			Patch
A	[revision details]	View	1	1 chunk	+2 lines, -0 lines	0 comments	Download
M	state/service.go	View	1	1 chunk	+6 lines, -0 lines	0 comments	Download
M	state/service_test.go	View		2 chunks	+6 lines, -0 lines	0 comments	Download

Messages

Total messages: 3

Expand All Messages | Collapse All Messages

niemeyer

LGTM https://codereview.appspot.com/6570064/diff/1/state/service.go File state/service.go (right): https://codereview.appspot.com/6570064/diff/1/state/service.go#newcode118 state/service.go:118: func (s *Service) CharmURL() (*charm.URL, bool) { (curl ...

11 years, 7 months ago (2012-09-28 17:16:04 UTC) #2

fwereade

11 years, 7 months ago (2012-09-28 22:43:38 UTC) #3

*** Submitted:

state: add CharmURL() to Service

R=niemeyer
CC=
https://codereview.appspot.com/6570064

https://codereview.appspot.com/6570064/diff/1/state/service.go
File state/service.go (right):

https://codereview.appspot.com/6570064/diff/1/state/service.go#newcode118
state/service.go:118: func (s *Service) CharmURL() (*charm.URL, bool) {
On 2012/09/28 17:16:04, niemeyer wrote:
> (curl *charm.URL, force bool)
> 
> Just to get the meaning of the bool in the prototype.

Done.

Expand All Messages | Collapse All Messages