Issue 6570050: jujud: sane args in bootstrap test

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Issue 6570050: jujud: sane args in bootstrap test

Can't Edit
Can't Publish+Mail
Start Review

Created:
11 years, 7 months ago by fwereade

Modified:
11 years, 7 months ago

Reviewers:
mp+126344

Visibility:
Public.

Description

jujud: sane args in bootstrap test Fixes one failure only. https://code.launchpad.net/~fwereade/juju-core/trivial-jujud-test-fix/+merge/126344 (do not edit description out of merge proposal)

Patch Set 2 : jujud: sane args in bootstrap test #

Created: 11 years, 7 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+8 lines, -1 line)			Patch
	A	[revision details]	View	1	1 chunk	+2 lines, -0 lines	0 comments	Download
	M	cmd/jujud/bootstrap_test.go	View		1 chunk	+6 lines, -1 line	0 comments	Download

Messages

Total messages: 3

Expand All Messages | Collapse All Messages

niemeyer

LGTM https://codereview.appspot.com/6570050/diff/1/cmd/jujud/bootstrap_test.go File cmd/jujud/bootstrap_test.go (right): https://codereview.appspot.com/6570050/diff/1/cmd/jujud/bootstrap_test.go#newcode56 cmd/jujud/bootstrap_test.go:56: }.encode()) Hah. https://codereview.appspot.com/6570050/diff/1/cmd/jujud/provisioning_test.go File cmd/jujud/provisioning_test.go (right): https://codereview.appspot.com/6570050/diff/1/cmd/jujud/provisioning_test.go#newcode8 cmd/jujud/provisioning_test.go:8: ...

11 years, 7 months ago (2012-09-25 22:59:08 UTC) #2

fwereade

11 years, 7 months ago (2012-09-25 23:41:42 UTC) #3

*** Submitted:

jujud: sane args in bootstrap test

Fixes one failure only.

R=niemeyer
CC=
https://codereview.appspot.com/6570050

Expand All Messages | Collapse All Messages