Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(1567)

Issue 6566060: environs/jujutest: print environ config in tests

Can't Edit
Can't Publish+Mail
Start Review
Created:
11 years, 7 months ago by rog
Modified:
11 years, 7 months ago
Reviewers:
mp+126661
Visibility:
Public.

Description

environs/jujutest: print environ config in tests It's useful to be able to connect to a environment that's being created during go test; by printing the environment config, we make this easier (especially as the %#v output is JSON-compatible, so we can more-or-less directly paste it into an environments.yaml file). https://code.launchpad.net/~rogpeppe/juju-core/086-print-livetest-configuration/+merge/126661 (do not edit description out of merge proposal)

Patch Set 1 #

Patch Set 2 : environs/jujutest: print environ config in tests #

Unified diffs Side-by-side diffs Delta from patch set Stats (+17 lines, -1 line) Patch
A [revision details] View 1 chunk +2 lines, -0 lines 0 comments Download
M environs/interface.go View 1 chunk +1 line, -1 line 0 comments Download
M environs/jujutest/test.go View 1 chunk +14 lines, -0 lines 0 comments Download

Messages

Total messages: 3
rog
Please take a look.
11 years, 7 months ago (2012-09-27 10:51:32 UTC) #1
fwereade
Nice, LGTM
11 years, 7 months ago (2012-09-27 10:53:07 UTC) #2
rog
11 years, 7 months ago (2012-09-27 10:58:28 UTC) #3
*** Submitted:

environs/jujutest: print environ config in tests

It's useful to be able to connect to a environment
that's being created during go test; by printing
the environment config, we make this easier
(especially as the %#v output is JSON-compatible,
so we can more-or-less directly paste it into
an environments.yaml file).

R=fwereade
CC=
https://codereview.appspot.com/6566060
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld f62528b