Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(3065)

Issue 6565057: state: use strings as resolution modes

Can't Edit
Can't Publish+Mail
Start Review
Created:
11 years, 7 months ago by niemeyer
Modified:
11 years, 7 months ago
Reviewers:
mp+126700, fwereade
Visibility:
Public.

Description

state: use strings as resolution modes That's what we do in most places, it's easier to debug, and there's no real advantage in not having it in that specific case at least. https://code.launchpad.net/~niemeyer/juju-core/string-resolution-modes/+merge/126700 (do not edit description out of merge proposal)

Patch Set 1 #

Patch Set 2 : state: use strings as resolution modes #

Unified diffs Side-by-side diffs Delta from patch set Stats (+12 lines, -9 lines) Patch
A [revision details] View 1 chunk +2 lines, -0 lines 0 comments Download
M state/unit.go View 2 chunks +8 lines, -7 lines 0 comments Download
M state/unit_test.go View 1 chunk +2 lines, -2 lines 0 comments Download

Messages

Total messages: 3
niemeyer
Please take a look.
11 years, 7 months ago (2012-09-27 14:29:54 UTC) #1
fwereade
LGTM!
11 years, 7 months ago (2012-09-27 14:31:03 UTC) #2
niemeyer
11 years, 7 months ago (2012-09-27 14:33:50 UTC) #3
*** Submitted:

state: use strings as resolution modes

That's what we do in most places, it's easier to debug, and
there's no real advantage in not having it in that specific
case at least.

R=fwereade
CC=
https://codereview.appspot.com/6565057
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld f62528b