code review 65630046: cmd/pack: fix match

cmd/pack: fix match

Match used len(ar.files) == 0 to mean "match everything"
but it also deleted matched things from the list, so once you
had matched everything you asked for, match returned true
for whatever was left in the archive too.

Concretely, if you have an archive containing f1, f2, then
        pack t foo.a f1
would match f1 and then, because len(ar.files) == 0 after
deleting f1 from the match list, also match f2.

Avoid the problem by recording explicitly whether match
matches everything.

[rsc, 2014-02-20 01:34:25]

Hello r (cc: dsymonds, golang-codereviews@googlegroups.com),

I'd like you to review this change to
https://code.google.com/p/go/

[r, 2014-02-20 01:36:20]

LGTM

[dsymonds, 2014-02-20 01:40:03]

LGTM

This improves my situation.

[rsc, 2014-02-20 20:50:34]

*** Submitted as https://code.google.com/p/go/source/detail?r=50c8fc924389 ***

cmd/pack: fix match

Match used len(ar.files) == 0 to mean "match everything"
but it also deleted matched things from the list, so once you
had matched everything you asked for, match returned true
for whatever was left in the archive too.

Concretely, if you have an archive containing f1, f2, then
        pack t foo.a f1
would match f1 and then, because len(ar.files) == 0 after
deleting f1 from the match list, also match f2.

Avoid the problem by recording explicitly whether match
matches everything.

LGTM=r, dsymonds
R=r, dsymonds
CC=golang-codereviews
https://codereview.appspot.com/65630046

[gobot, 2014-02-20 20:56:04]

This CL appears to have broken the freebsd-amd64 builder.