Better descripion of errors in notifications.

Better descripion of errors in notifications.

Currently notifications contain only "User actions suggested..."  The
messages need to provide more insight into what the failure was.

https://code.launchpad.net/~bac/juju-ui/notify-errs/+merge/126672

(do not edit description out of merge proposal)

[bac, 2012-09-27 20:16:11]

Please take a look.

[benjamin.saller, 2012-09-28 00:43:32]

LGTM after a trunk merge.

As a minor I think it would be a good idea to change the template(s) to indicate
error status messages in a special way. I suspect in the near future we'll want
messages from user-action to appear in the list w/o being errors and so some
style on them would help. If you don't have ideas about what the style should be
just tag it with a class :)

Thanks

https://codereview.appspot.com/6561066/diff/1/app/app.js
File app/app.js (left):

https://codereview.appspot.com/6561066/diff/1/app/app.js#oldcode64
app/app.js:64: charm_search: {
Looks like you have to merge trunk?

[bac, 2012-09-28 11:42:12]

*** Submitted:

Better descripion of errors in notifications.

Currently notifications contain only "User actions suggested..."  The
messages need to provide more insight into what the failure was.

R=benjamin.saller
CC=
https://codereview.appspot.com/6561066

https://codereview.appspot.com/6561066/diff/1/app/app.js
File app/app.js (left):

https://codereview.appspot.com/6561066/diff/1/app/app.js#oldcode64
app/app.js:64: charm_search: {
On 2012/09/28 00:43:32, benjamin.saller wrote:
> Looks like you have to merge trunk?


No this branch also removes search.js as requested by Kapil as it isn't used by
the simplified, temporary approach.  Thiago's branch will re-do it cleanly.

[hazmat, 2012-09-28 15:12:54]

there's a significant issue with this cleanup, although not directly related to
the work here, namely that its using assuming the client side sync op is
representative of the server side op, when in fact its not, because from the
perspective of the client-side db. 

The solution would be to distinguish notification strings in the notifier based
on the sync state (initial vs subsequent).

https://codereview.appspot.com/6561066/diff/8/test/test_notifications.js
File test/test_notifications.js (right):

https://codereview.appspot.com/6561066/diff/8/test/test_notifications.js#newc...
test/test_notifications.js:306: showable[0].title.should.equal('Error with add
unit');
Delta stream ops do not directly correspond without additional context (is it
past the initial sync) to the corresponding environment action. else your
reporting add errors on things that have been alive for quite a while.