Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(2088)

Issue 6561056: Make SampleApp work on iPhone/iOS simulator. (Closed)

Can't Edit
Can't Publish+Mail
Start Review
Created:
11 years, 7 months ago by bsalomon
Modified:
11 years, 7 months ago
Reviewers:
caryclark1, reed1
CC:
skia-review_googlegroups.com
Base URL:
http://skia.googlecode.com/svn/trunk/
Visibility:
Public.

Description

Make SampleApp work on iPhone/iOS simulator. Several parts to this: 1) The DeviceManager subclass for iOS was rewritten because the base class changed. 2) Two old samples that rely on hardcoded paths to images are deleted. They hit assertions in SkImageRef. No one has the required images to run these anyway. 3) argv must be non-NULL. 4) The UI delegate must not be loaded from the NIB for viewDidLoad ordering reasons. So I removed an IBOutlet link from the window to the splitview controller in the iPad's NIB file. The split view is attached by the AppDelegate programmatically. This doesn't make GPU work. That will come in a later change.

Patch Set 1 #

Patch Set 2 : #

Patch Set 3 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+220 lines, -900 lines) Patch
M experimental/iOSSampleApp/SkSampleUIView.mm View 1 2 chunks +151 lines, -65 lines 0 comments Download
M experimental/iOSSampleApp/iPad/MainWindow_iPad.xib View 1 2 25 chunks +69 lines, -353 lines 0 comments Download
M gyp/SampleApp.gyp View 1 1 chunk +0 lines, -2 lines 0 comments Download
M samplecode/SampleImage.cpp View 1 1 chunk +0 lines, -163 lines 0 comments Download
M samplecode/SampleImageDir.cpp View 1 1 chunk +0 lines, -317 lines 0 comments Download

Messages

Total messages: 4
bsalomon
11 years, 7 months ago (2012-09-26 20:28:13 UTC) #1
bsalomon
Adding Mike since Cary is out of the office today.
11 years, 7 months ago (2012-09-27 15:12:54 UTC) #2
reed1
(closes eyes) LGTM
11 years, 7 months ago (2012-09-27 15:24:33 UTC) #3
bsalomon
11 years, 7 months ago (2012-09-27 16:05:06 UTC) #4
Checked in at r5712.
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld f62528b