Issue 6560066: version: add Build number

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Issue 6560066: version: add Build number

Can't Edit
Can't Publish+Mail
Start Review

Created:
11 years, 6 months ago by rog

Modified:
11 years, 6 months ago

Reviewers:
mp+127024

Visibility:
Public.

Description

version: add Build number This will be used to implement upgrade --bump-version. https://code.launchpad.net/~rogpeppe/juju-core/094-version-build/+merge/127024 (do not edit description out of merge proposal)

Patch Set 1 #

Patch Set 2 : version: add Build number #

Total comments: 4

Patch Set 3 : version: add Build number #

Created: 11 years, 6 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+55 lines, -18 lines)			Patch
A	[revision details]	View	1 2	1 chunk	+2 lines, -0 lines	0 comments	Download
M	state/machine_test.go	View		1 chunk	+3 lines, -1 line	0 comments	Download
M	version/version.go	View	1 2	7 chunks	+27 lines, -12 lines	0 comments	Download
M	version/version_test.go	View	1 2	4 chunks	+23 lines, -5 lines	0 comments	Download

Messages

Total messages: 3

Expand All Messages | Collapse All Messages

niemeyer

LGTM https://codereview.appspot.com/6560066/diff/2001/version/version.go File version/version.go (right): https://codereview.appspot.com/6560066/diff/2001/version/version.go#newcode42 version/version.go:42: // and patch are reset. The build number ...

11 years, 6 months ago (2012-09-28 16:47:35 UTC) #2

rog

11 years, 6 months ago (2012-09-28 17:06:58 UTC) #3

*** Submitted:

version: add Build number

This will be used to implement upgrade --bump-version.

R=niemeyer
CC=
https://codereview.appspot.com/6560066

https://codereview.appspot.com/6560066/diff/2001/version/version.go
File version/version.go (right):

https://codereview.appspot.com/6560066/diff/2001/version/version.go#newcode42
version/version.go:42: // and patch are reset. The build number represents a
build version.
On 2012/09/28 16:47:35, niemeyer wrote:
> // ... The build number is automatically assigned
> // and has no well defined sequence. If the build number is
> // greater than zero or any of the other numbers are odd, it
> // indicates that the release is still in development.

Done.

https://codereview.appspot.com/6560066/diff/2001/version/version.go#newcode210
version/version.go:210: return isOdd(v.Major) || isOdd(v.Minor) ||
isOdd(v.Patch)
On 2012/09/28 16:47:35, niemeyer wrote:
> || v.Build > 0

Done.

Expand All Messages | Collapse All Messages