Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(848)

Issue 6560056: Change type of static cast to legal/correct base type.

Can't Edit
Can't Publish+Mail
Start Review
Created:
11 years, 7 months ago by cmtice
Modified:
9 years, 4 months ago
Reviewers:
Geoff Pike, antonm1, antonm
Base URL:
http://git.chromium.org/external/WebKit_trimmed.git@master
Visibility:
Public.

Description

Change type of static cast to legal/correct base type. On line 337, the static cast of ownerElement to an HTMLFrameElement was not correct, because sometimes ownerElement could contain an HTMLIFrameElement. HTMLIFrameElement is a sibling class of HTMLFrameElement. The correct static cast is to an HTMLFrameElementBase, which is a base class for both of the other classes. This correctness change is required for upcoming compiler changes. BUG=none TEST=made source change; emerge-stumpy chromeos-chrome; ran in VM.

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -1 line) Patch
M Source/WebCore/page/FrameView.cpp View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 2
Geoff Pike
LGTM. Anton, what do you think?
11 years, 6 months ago (2012-10-04 20:35:48 UTC) #1
antonm1
11 years, 6 months ago (2012-10-05 11:59:35 UTC) #2
Thanks a lot and LGTM
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld f62528b