Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(1729)

Issue 6560045: testing: don't panic if mongod is missing (Closed)

Can't Edit
Can't Publish+Mail
Start Review
Created:
10 years, 2 months ago by dfc
Modified:
10 years, 2 months ago
Reviewers:
mp+126133
Visibility:
Public.

Description

testing: don't panic if mongod is missing While sad, this isn't a cause for panic. Also, fix mgo_test.go to run the test suite. https://code.launchpad.net/~dave-cheney/juju-core/002-mgo-dont-panic/+merge/126133 (do not edit description out of merge proposal)

Patch Set 1 #

Patch Set 2 : testing: don't panic if mongod is missing #

Total comments: 8

Patch Set 3 : testing: don't panic if mongod is missing #

Patch Set 4 : testing: don't panic if mongod is missing #

Unified diffs Side-by-side diffs Delta from patch set Stats (+22 lines, -11 lines) Patch
A [revision details] View 1 2 1 chunk +2 lines, -0 lines 0 comments Download
M testing/mgo.go View 1 2 3 chunks +9 lines, -6 lines 0 comments Download
M testing/mgo_test.go View 1 2 1 chunk +11 lines, -5 lines 0 comments Download

Messages

Total messages: 6
dfc
Please take a look.
10 years, 2 months ago (2012-09-25 00:52:47 UTC) #1
dfc
Please take a look.
10 years, 2 months ago (2012-09-25 01:49:53 UTC) #2
niemeyer
https://codereview.appspot.com/6560045/diff/3001/testing/mgo.go File testing/mgo.go (right): https://codereview.appspot.com/6560045/diff/3001/testing/mgo.go#newcode29 testing/mgo.go:29: func StartMgoServer(t *stdtesting.T) (server *exec.Cmd, dbdir string) { Just ...
10 years, 2 months ago (2012-09-25 14:11:56 UTC) #3
dfc
Please take a look. https://codereview.appspot.com/6560045/diff/3001/testing/mgo.go File testing/mgo.go (right): https://codereview.appspot.com/6560045/diff/3001/testing/mgo.go#newcode29 testing/mgo.go:29: func StartMgoServer(t *stdtesting.T) (server *exec.Cmd, ...
10 years, 2 months ago (2012-09-26 01:27:30 UTC) #4
niemeyer
LGTM
10 years, 2 months ago (2012-09-26 01:37:50 UTC) #5
dfc
10 years, 2 months ago (2012-09-26 01:40:00 UTC) #6
*** Submitted:

testing: don't panic if mongod is missing

While sad, this isn't a cause for panic.

Also, fix mgo_test.go to run the test suite.

R=niemeyer
CC=
https://codereview.appspot.com/6560045
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld f62528b