Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(522)

Issue 6555052: code review 6555052: crypto/x509: add DecryptBlock function for loading pass...

Can't Edit
Can't Publish+Mail
Start Review
Created:
10 years, 2 months ago by zeebo
Modified:
10 years, 2 months ago
Reviewers:
agl1
CC:
golang-dev, agl1, zeeboo
Visibility:
Public.

Description

crypto/x509: add DecryptBlock function for loading password protected keys Adds a DecryptBlock function which takes a password and a *pem.Block and returns the decrypted DER bytes suitable for passing into other crypto/x509 functions.

Patch Set 1 #

Patch Set 2 : diff -r 24d74bd32d81 https://code.google.com/p/go #

Patch Set 3 : diff -r 24d74bd32d81 https://code.google.com/p/go #

Total comments: 31

Patch Set 4 : code review 6555052: crypto/x509: add DecryptBlock function for loading pass... #

Patch Set 5 : code review 6555052: crypto/x509: add DecryptBlock function for loading pass... #

Patch Set 6 : diff -r 44b9f2d5eb03 https://code.google.com/p/go #

Total comments: 9

Patch Set 7 : diff -r 96fde1b15506 https://code.google.com/p/go #

Patch Set 8 : diff -r 96fde1b15506 https://code.google.com/p/go #

Unified diffs Side-by-side diffs Delta from patch set Stats (+252 lines, -0 lines) Patch
A src/pkg/crypto/x509/pem_decrypt.go View 1 2 3 4 5 6 7 1 chunk +133 lines, -0 lines 0 comments Download
A src/pkg/crypto/x509/pem_decrypt_test.go View 1 2 3 4 5 6 1 chunk +119 lines, -0 lines 0 comments Download

Messages

Total messages: 12
zeebo
Hello golang-dev@googlegroups.com, I'd like you to review this change to https://code.google.com/p/go
10 years, 2 months ago (2012-09-22 00:02:26 UTC) #1
agl1
https://codereview.appspot.com/6555052/diff/4001/src/pkg/crypto/x509/block_decrypt.go File src/pkg/crypto/x509/block_decrypt.go (right): https://codereview.appspot.com/6555052/diff/4001/src/pkg/crypto/x509/block_decrypt.go#newcode1 src/pkg/crypto/x509/block_decrypt.go:1: package x509 Copyright missing. https://codereview.appspot.com/6555052/diff/4001/src/pkg/crypto/x509/block_decrypt.go#newcode1 src/pkg/crypto/x509/block_decrypt.go:1: package x509 block_decrypt.go ...
10 years, 2 months ago (2012-09-24 14:55:27 UTC) #2
zeebo
Hello golang-dev@googlegroups.com, agl@golang.org (cc: golang-dev@googlegroups.com), Please take another look.
10 years, 2 months ago (2012-09-24 15:29:41 UTC) #3
zeeboo
PTAL http://codereview.appspot.com/6555052/diff/4001/src/pkg/crypto/x509/block_decrypt.go File src/pkg/crypto/x509/block_decrypt.go (right): http://codereview.appspot.com/6555052/diff/4001/src/pkg/crypto/x509/block_decrypt.go#newcode1 src/pkg/crypto/x509/block_decrypt.go:1: package x509 On 2012/09/24 14:55:27, agl1 wrote: > ...
10 years, 2 months ago (2012-09-24 15:29:54 UTC) #4
agl1
https://codereview.appspot.com/6555052/diff/11001/src/pkg/crypto/x509/pem_decrypt.go File src/pkg/crypto/x509/pem_decrypt.go (right): https://codereview.appspot.com/6555052/diff/11001/src/pkg/crypto/x509/pem_decrypt.go#newcode1 src/pkg/crypto/x509/pem_decrypt.go:1: // Copyright 2011 The Go Authors. All rights reserved. ...
10 years, 2 months ago (2012-09-24 22:08:11 UTC) #5
agl1
On Mon, Sep 24, 2012 at 6:08 PM, <agl@golang.org> wrote: > If the password is ...
10 years, 2 months ago (2012-09-24 22:11:37 UTC) #6
zeebo
PTAL https://codereview.appspot.com/6555052/diff/11001/src/pkg/crypto/x509/pem_decrypt.go File src/pkg/crypto/x509/pem_decrypt.go (right): https://codereview.appspot.com/6555052/diff/11001/src/pkg/crypto/x509/pem_decrypt.go#newcode57 src/pkg/crypto/x509/pem_decrypt.go:57: On 2012/09/24 22:08:11, agl1 wrote: > Do we ...
10 years, 2 months ago (2012-09-24 22:25:49 UTC) #7
agl1
LGTM with that last function. https://codereview.appspot.com/6555052/diff/11001/src/pkg/crypto/x509/pem_decrypt.go File src/pkg/crypto/x509/pem_decrypt.go (right): https://codereview.appspot.com/6555052/diff/11001/src/pkg/crypto/x509/pem_decrypt.go#newcode57 src/pkg/crypto/x509/pem_decrypt.go:57: On 2012/09/24 22:25:49, zeebo ...
10 years, 2 months ago (2012-09-24 22:30:57 UTC) #8
zeebo
PTAL
10 years, 2 months ago (2012-09-24 22:36:28 UTC) #9
agl1
On Mon, Sep 24, 2012 at 6:36 PM, <jeff@spacemonkey.com> wrote: > PTAL (Sorry, just noticed ...
10 years, 2 months ago (2012-09-27 13:44:23 UTC) #10
zeebo
On 2012/09/27 13:44:23, agl1 wrote: > On Mon, Sep 24, 2012 at 6:36 PM, <mailto:jeff@spacemonkey.com> ...
10 years, 2 months ago (2012-10-04 19:09:30 UTC) #11
agl1
10 years, 2 months ago (2012-10-04 19:43:16 UTC) #12
*** Submitted as http://code.google.com/p/go/source/detail?r=8230013d1c40 ***

crypto/x509: add DecryptBlock function for loading password protected keys

Adds a DecryptBlock function which takes a password and a *pem.Block and
returns the decrypted DER bytes suitable for passing into other crypto/x509
functions.

R=golang-dev, agl, leterip
CC=golang-dev
http://codereview.appspot.com/6555052

Committer: Adam Langley <agl@golang.org>
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld f62528b