Issue 6555043: builddb: new tool for building mongodb from source

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Issue 6555043: builddb: new tool for building mongodb from source

Can't Edit
Can't Publish+Mail
Start Review

Created:
11 years, 7 months ago by niemeyer

Modified:
11 years, 7 months ago

Reviewers:
mp+125502, dave

Visibility:
Public.

Description

builddb: new tool for building mongodb from source https://code.launchpad.net/~niemeyer/juju-core/builddb/+merge/125502 (do not edit description out of merge proposal)

Patch Set 1 #

Total comments: 2

Patch Set 2 : builddb: new tool for building mongodb from source #

Created: 11 years, 7 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+116 lines, -0 lines)			Patch
A	[revision details]	View	1	1 chunk	+2 lines, -0 lines	0 comments	Download
A	util/builddb/main.go	View	1	1 chunk	+77 lines, -0 lines	0 comments	Download
A	util/builddb/precise/builddb/hooks/install	View	1	1 chunk	+28 lines, -0 lines	0 comments	Download
A	util/builddb/precise/builddb/hooks/start	View	1	1 chunk	+5 lines, -0 lines	0 comments	Download
A	util/builddb/precise/builddb/metadata.yaml	View	1	1 chunk	+4 lines, -0 lines	0 comments	Download

Messages

Total messages: 3

Expand All Messages | Collapse All Messages

dave_cheney.net

LGTM. My only significant comment would be to not make this a top level package. ...

11 years, 7 months ago (2012-09-20 15:12:35 UTC) #2

niemeyer

11 years, 7 months ago (2012-09-20 15:16:49 UTC) #3

*** Submitted:

builddb: new tool for building mongodb from source

R=dfc
CC=
https://codereview.appspot.com/6555043

https://codereview.appspot.com/6555043/diff/1/builddb/main.go
File builddb/main.go (right):

https://codereview.appspot.com/6555043/diff/1/builddb/main.go#newcode15
builddb/main.go:15: "path/filepath"
On 2012/09/20 15:12:35, dfc wrote:
> pls move these lines to the top, leaving the provider import by itself.

Done.

Expand All Messages | Collapse All Messages