Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(13)

Issue 6554067: code review 6554067: reflect: add MakeFunc (API CHANGE) (Closed)

Can't Edit
Can't Publish+Mail
Start Review
Created:
9 years, 9 months ago by rsc
Modified:
9 years, 9 months ago
Reviewers:
CC:
iant, r, DMorsing, minux1, bradfitzgoog, rog, remyoudompheng, golang-dev
Visibility:
Public.

Description

reflect: add MakeFunc (API CHANGE) Fixes issue 1765.

Patch Set 1 #

Patch Set 2 : diff -r d91e3e7106aa https://code.google.com/p/go/ #

Total comments: 15

Patch Set 3 : diff -r d91e3e7106aa https://code.google.com/p/go/ #

Patch Set 4 : diff -r d91e3e7106aa https://code.google.com/p/go/ #

Total comments: 4

Patch Set 5 : diff -r a203e3118c5d https://code.google.com/p/go/ #

Patch Set 6 : diff -r a203e3118c5d https://code.google.com/p/go/ #

Total comments: 14

Patch Set 7 : diff -r 29cff1e8de4e https://code.google.com/p/go/ #

Patch Set 8 : diff -r 29cff1e8de4e https://code.google.com/p/go/ #

Total comments: 20

Patch Set 9 : diff -r 0ece4ff29314 https://go.googlecode.com/hg/ #

Total comments: 14

Patch Set 10 : diff -r 0ece4ff29314 https://go.googlecode.com/hg/ #

Patch Set 11 : diff -r 96fde1b15506 https://code.google.com/p/go/ #

Unified diffs Side-by-side diffs Delta from patch set Stats (+377 lines, -7 lines) Patch
M src/pkg/reflect/all_test.go View 1 2 3 4 5 6 1 chunk +40 lines, -7 lines 0 comments Download
A src/pkg/reflect/asm_386.s View 1 2 1 chunk +18 lines, -0 lines 0 comments Download
A src/pkg/reflect/asm_amd64.s View 1 2 1 chunk +18 lines, -0 lines 0 comments Download
A src/pkg/reflect/asm_arm.s View 1 2 1 chunk +17 lines, -0 lines 0 comments Download
A src/pkg/reflect/example_test.go View 1 2 3 4 5 6 7 8 1 chunk +52 lines, -0 lines 0 comments Download
A src/pkg/reflect/makefunc.go View 1 2 3 4 5 6 7 8 9 10 1 chunk +156 lines, -0 lines 0 comments Download
M src/pkg/reflect/value.go View 1 2 3 4 5 6 1 chunk +76 lines, -0 lines 0 comments Download

Messages

Total messages: 26
rsc
Hello iant, r (cc: golang-dev@googlegroups.com), I'd like you to review this change to https://code.google.com/p/go/
9 years, 9 months ago (2012-09-22 14:17:14 UTC) #1
DMorsing
http://codereview.appspot.com/6554067/diff/3/src/pkg/reflect/value.go File src/pkg/reflect/value.go (right): http://codereview.appspot.com/6554067/diff/3/src/pkg/reflect/value.go#newcode651 src/pkg/reflect/value.go:651: switch runtime.GOARCH { Could this be moved into a ...
9 years, 9 months ago (2012-09-22 16:53:31 UTC) #2
rsc
http://codereview.appspot.com/6554067/diff/3/src/pkg/reflect/value.go File src/pkg/reflect/value.go (right): http://codereview.appspot.com/6554067/diff/3/src/pkg/reflect/value.go#newcode651 src/pkg/reflect/value.go:651: switch runtime.GOARCH { On 2012/09/22 16:53:31, DMorsing wrote: > ...
9 years, 9 months ago (2012-09-22 16:58:30 UTC) #3
minux1
Sigh, one more place of dynamic code generation. Do you have plan to remove dyn. ...
9 years, 9 months ago (2012-09-22 17:48:12 UTC) #4
bradfitzgoog
Wow, nice surprise. Fixes issue nnnn. On Sep 22, 2012 7:17 AM, <rsc@golang.org> wrote: > ...
9 years, 9 months ago (2012-09-22 18:17:23 UTC) #5
r
this is one of the ugliest CLs i've ever seen. http://codereview.appspot.com/6554067/diff/3/src/pkg/reflect/asm_386.s File src/pkg/reflect/asm_386.s (right): http://codereview.appspot.com/6554067/diff/3/src/pkg/reflect/asm_386.s#newcode5 ...
9 years, 9 months ago (2012-09-22 18:44:19 UTC) #6
r
Minux is right about code generation, but given the variable type I don't see how ...
9 years, 9 months ago (2012-09-22 18:45:34 UTC) #7
rog
On 22 September 2012 19:45, Rob Pike <r@golang.org> wrote: > Minux is right about code ...
9 years, 9 months ago (2012-09-22 19:07:21 UTC) #8
rsc
On Sat, Sep 22, 2012 at 1:48 PM, minux <minux.ma@gmail.com> wrote: > Sigh, one more ...
9 years, 9 months ago (2012-09-22 23:23:55 UTC) #9
rsc
http://codereview.appspot.com/6554067/diff/3/src/pkg/reflect/asm_386.s File src/pkg/reflect/asm_386.s (right): http://codereview.appspot.com/6554067/diff/3/src/pkg/reflect/asm_386.s#newcode5 src/pkg/reflect/asm_386.s:5: TEXT ·callStub(SB),7,$12 On 2012/09/22 18:44:19, r wrote: > a ...
9 years, 9 months ago (2012-09-22 23:34:26 UTC) #10
rsc
Hello iant@golang.org, r@golang.org, daniel.morsing@gmail.com, minux.ma@gmail.com, bradfitz@google.com, rogpeppe@gmail.com (cc: golang-dev@googlegroups.com), Please take another look.
9 years, 9 months ago (2012-09-22 23:40:27 UTC) #11
r
is there urgent need for this? i don't have this itch to scratch. if it ...
9 years, 9 months ago (2012-09-23 01:07:56 UTC) #12
rsc
On Sat, Sep 22, 2012 at 9:07 PM, <r@golang.org> wrote: > is there urgent need ...
9 years, 9 months ago (2012-09-23 01:17:34 UTC) #13
rsc
Hello iant@golang.org, r@golang.org, daniel.morsing@gmail.com, minux.ma@gmail.com, bradfitz@google.com, rogpeppe@gmail.com (cc: golang-dev@googlegroups.com), Please take another look.
9 years, 9 months ago (2012-09-23 01:24:11 UTC) #14
iant
LGTM https://codereview.appspot.com/6554067/diff/9003/src/pkg/reflect/all_test.go File src/pkg/reflect/all_test.go (right): https://codereview.appspot.com/6554067/diff/9003/src/pkg/reflect/all_test.go#newcode1428 src/pkg/reflect/all_test.go:1428: var f func(byte, int, byte, two, byte) (byte, ...
9 years, 9 months ago (2012-09-23 05:10:54 UTC) #15
r
https://codereview.appspot.com/6554067/diff/9003/src/pkg/reflect/example_test.go File src/pkg/reflect/example_test.go (right): https://codereview.appspot.com/6554067/diff/9003/src/pkg/reflect/example_test.go#newcode28 src/pkg/reflect/example_test.go:28: reflect.ValueOf(fptr).Elem().Set(v) this line needs explanation. https://codereview.appspot.com/6554067/diff/9003/src/pkg/reflect/makefunc.go File src/pkg/reflect/makefunc.go (right): ...
9 years, 9 months ago (2012-09-23 05:56:08 UTC) #16
rsc
PTAL https://codereview.appspot.com/6554067/diff/11/src/pkg/reflect/value.go File src/pkg/reflect/value.go (right): https://codereview.appspot.com/6554067/diff/11/src/pkg/reflect/value.go#newcode627 src/pkg/reflect/value.go:627: // results returned to the caller. On 2012/09/23 ...
9 years, 9 months ago (2012-09-23 17:51:53 UTC) #17
remyoudompheng
How does it interact with variadic function types? The supplied func([]Value) []Value must behave like ...
9 years, 9 months ago (2012-09-23 18:03:03 UTC) #18
rsc
On Sun, Sep 23, 2012 at 2:03 PM, <remyoudompheng@gmail.com> wrote: > How does it interact ...
9 years, 9 months ago (2012-09-23 18:15:28 UTC) #19
r
http://codereview.appspot.com/6554067/diff/20/src/pkg/reflect/example_test.go File src/pkg/reflect/example_test.go (right): http://codereview.appspot.com/6554067/diff/20/src/pkg/reflect/example_test.go#newcode24 src/pkg/reflect/example_test.go:24: // into Values, calls swap, and then turns swaps ...
9 years, 9 months ago (2012-09-23 20:41:24 UTC) #20
r
http://codereview.appspot.com/6554067/diff/20/src/pkg/reflect/makefunc.go File src/pkg/reflect/makefunc.go (right): http://codereview.appspot.com/6554067/diff/20/src/pkg/reflect/makefunc.go#newcode31 src/pkg/reflect/makefunc.go:31: // - return the values listed in out. my ...
9 years, 9 months ago (2012-09-23 20:42:26 UTC) #21
rsc
PTAL http://codereview.appspot.com/6554067/diff/20/src/pkg/reflect/example_test.go File src/pkg/reflect/example_test.go (right): http://codereview.appspot.com/6554067/diff/20/src/pkg/reflect/example_test.go#newcode24 src/pkg/reflect/example_test.go:24: // into Values, calls swap, and then turns ...
9 years, 9 months ago (2012-09-24 19:59:15 UTC) #22
r
comments almost there http://codereview.appspot.com/6554067/diff/12011/src/pkg/reflect/makefunc.go File src/pkg/reflect/makefunc.go (right): http://codereview.appspot.com/6554067/diff/12011/src/pkg/reflect/makefunc.go#newcode27 src/pkg/reflect/makefunc.go:27: // MakeFunc returns a new function ...
9 years, 9 months ago (2012-09-24 21:59:02 UTC) #23
rsc
PTAL http://codereview.appspot.com/6554067/diff/12011/src/pkg/reflect/makefunc.go File src/pkg/reflect/makefunc.go (right): http://codereview.appspot.com/6554067/diff/12011/src/pkg/reflect/makefunc.go#newcode27 src/pkg/reflect/makefunc.go:27: // MakeFunc returns a new function of the ...
9 years, 9 months ago (2012-09-24 22:07:59 UTC) #24
r
LGTM
9 years, 9 months ago (2012-09-24 22:34:33 UTC) #25
rsc
9 years, 9 months ago (2012-09-25 00:06:39 UTC) #26
*** Submitted as http://code.google.com/p/go/source/detail?r=c0b106409d18 ***

reflect: add MakeFunc (API CHANGE)

Fixes issue 1765.

R=iant, r, daniel.morsing, minux.ma, bradfitz, rogpeppe, remyoudompheng
CC=golang-dev
http://codereview.appspot.com/6554067
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld f62528b